Remove unneeded protocols for lookup classes #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlento
approved these changes
Apr 15, 2024
| from metricflow.specs.specs import TimeDimensionSpec | ||
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| class MetricLookup(MetricAccessor): | ||
| class MetricLookup: |
There was a problem hiding this comment.
I think the add_metric method here is the only "write" method in this class, and it's not called anywhere. Mind just renaming it to _add_metric so we don't have any "write" methods in the public interface?
| """Tracks semantic information for semantic models held in a set of SemanticModelContainers. | ||
|
|
||
| This implements the SemanticModelAccessors protocol, the interface type we use throughout the codebase. | ||
| This implements the SemanticModelLookups protocol, the interface type we use throughout the codebase. |
There was a problem hiding this comment.
Nit - remove this line and the next, they're outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deletes protocols used for
SemanticModelLookupandMetricLookupin an effort to reduce boilerplate code and improve developer experience when working with these classes. Discussed with @tlento here.Also copies over any missing docstrings from the base classes so that we won't lose that context.