Update get_semantic_models_for_measure to return just one semantic model
#1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlento
approved these changes
Apr 15, 2024
Comment on lines
723
to
725
| return { | ||
| self._semantic_model_lookup.get_semantic_model_for_measure(measure.reference).name for measure in measures | ||
| } |
There was a problem hiding this comment.
Do you mind deleting this function and moving this one-liner over to where we call it? I think the docstring is super duper outdated and your change here removed all of the complexity from getting this set.
courtneyholcomb
force-pushed
the
court/clean
branch
from
14b0733 to
70bd329
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Measure names are required to be unique across semantic models, so we can safely assume that
get_semantic_models_for_measure()should return one semantic model per measure.