Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric filters for distinct values queries #1107

Merged
merged 9 commits into from
Apr 9, 2024
Merged

Metric filters for distinct values queries #1107

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
33314f1
Add LinkableMetrics to linkable elements for no metric queries
courtneyholcomb Mar 30, 2024
192fb25
Add query rendering tests
courtneyholcomb Mar 30, 2024
34b5393
Add integration tests
courtneyholcomb Mar 30, 2024
55a4a31
DFP cleanup
courtneyholcomb Mar 30, 2024
5a89ac6
Changelog
courtneyholcomb Mar 30, 2024
4048f47
Update SQL engine snapshots
courtneyholcomb Mar 30, 2024
2d45143
Fix group by syntax in integration test
courtneyholcomb Apr 2, 2024
4535ddb
Merge main
courtneyholcomb Apr 9, 2024
a723b11
Spelling
courtneyholcomb Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions metricflow/dataflow/builder/dataflow_plan_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,9 +640,7 @@ def _build_plan_for_distinct_values(self, query_spec: MetricFlowQuerySpec) -> Da
)

query_level_filter_specs = filter_spec_factory.create_from_where_filter_intersection(
filter_location=WhereFilterLocation.for_query(
tuple(metric_spec.reference for metric_spec in query_spec.metric_specs)
),
filter_location=WhereFilterLocation.for_query(metric_references=tuple()),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know, it took me way too long to figure out why there were no metric specs in this query. 🤦

filter_intersection=query_spec.filter_intersection,
)

Expand Down