Remove unsupported legacy MetricFlow Client API #1094
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original version of MetricFlow we supported a Python
client for programmatically issuing queries. This was a thin
wrapper over our internal APIs for running queries against
SQL engines.
Since the acquisition of Transform by dbt Labs the direction of
MetricFlow has shifted heavily (and appropriately) in the direction
of being a support library for building and rendering metric queries
against target query dialects (currently all SQL).
This legacy public API has not been maintained at all - it uses legacy
string-typed inputs, it does not support saved queries, and it allows
for a highly limited scope set of operations.
Furthermore, it is in a package directory path that indicates we have
a public API. Since we do not, in fact, have a supported public API
just yet, it behooves us to remove this in order to unblock some
efforts to simplify our internals and move us closer to the point
where we can build out a publicly supported API, whenever that time
may be.