Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupported legacy MetricFlow Client API #1094

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

tlento
Copy link
Contributor

@tlento tlento commented Mar 21, 2024

In the original version of MetricFlow we supported a Python
client for programmatically issuing queries. This was a thin
wrapper over our internal APIs for running queries against
SQL engines.

Since the acquisition of Transform by dbt Labs the direction of
MetricFlow has shifted heavily (and appropriately) in the direction
of being a support library for building and rendering metric queries
against target query dialects (currently all SQL).

This legacy public API has not been maintained at all - it uses legacy
string-typed inputs, it does not support saved queries, and it allows
for a highly limited scope set of operations.

Furthermore, it is in a package directory path that indicates we have
a public API. Since we do not, in fact, have a supported public API
just yet, it behooves us to remove this in order to unblock some
efforts to simplify our internals and move us closer to the point
where we can build out a publicly supported API, whenever that time
may be.

@cla-bot cla-bot bot added the cla:yes label Mar 21, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

In the original version of MetricFlow we supported a Python
client for programmatically issuing queries. This was a thin
wrapper over our internal APIs for running queries against
SQL engines.

Since the acquisition of Transform by dbt Labs the direction of
MetricFlow has shifted heavily (and appropriately) in the direction
of being a support library for building and rendering metric queries
against target query dialects (currently all SQL).

This legacy public API has not been maintained at all - it uses legacy
string-typed inputs, it does not support saved queries, and it allows
for a highly limited scope set of operations.

Furthermore, it is in a package directory path that indicates we have
a public API. Since we do not, in fact, have a supported public API
just yet, it behooves us to remove this in order to unblock some
efforts to simplify our internals and move us closer to the point
where we can build out a publicly supported API, whenever that time
may be.
@tlento tlento force-pushed the remove-legacy-metricflow-client branch from 438007b to ec6ebb2 Compare March 21, 2024 00:25
@tlento tlento marked this pull request as ready for review March 21, 2024 00:27
Copy link
Contributor

@WilliamDee WilliamDee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tlento tlento merged commit 7457aab into main Mar 21, 2024
10 checks passed
@tlento tlento deleted the remove-legacy-metricflow-client branch March 21, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants