Support CREATE TABLE ... AS SELECT in SQL Object Model
#1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
approved these changes
Mar 18, 2024
metricflow/sql/sql_plan.py
Outdated
| @property | ||
| @override | ||
| def description(self) -> str: | ||
| return "Create table {self." |
There was a problem hiding this comment.
looks like this didn't get finished!
plypaul
force-pushed
the
plypaul--09.3--ctas
branch
from
265ef74 to
07b902e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When generating the tasks for the execution plan, the
CREATE TABLE ... AS SELECTstatement was not generated through the SQL object model. Instead, it was generated when the associated task ran. For better consistency and to support potential SQL-engine differences, this PR adds the appropriate SQL node to model that statement. The execution task updates will be done in a separate PR.