Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP #1079

Closed
wants to merge 5 commits into from
Closed

WIP #1079

wants to merge 5 commits into from

Conversation

courtneyholcomb
Copy link
Contributor

Resolves #

Description

@cla-bot cla-bot bot added the cla:yes label Mar 13, 2024
@github-actions GitHub Actions
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

courtneyholcomb
courtneyholcomb commented Mar 20, 2024
View reviewed changes
metricflow/model/semantics/linkable_spec_resolver.py
@@ -518,6 +547,17 @@ def __init__(

self._metric_to_linkable_element_sets[metric.name] = linkable_sets_for_measure

# Linkable element lookup won't work unless this loop happens after the one above.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

courtneyholcomb
courtneyholcomb commented Mar 20, 2024
View reviewed changes
metricflow/plan_conversion/column_resolver.py
@@ -83,13 +84,26 @@ def visit_metadata_spec(self, metadata_spec: MetadataSpec) -> ColumnAssociation:
single_column_correlation_key=SingleColumnCorrelationKey(),
)

def visit_group_by_metric_spec(self, group_by_metric_spec: GroupByMetricSpec) -> ColumnAssociation: # noqa: D
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't do

courtneyholcomb
courtneyholcomb commented Mar 20, 2024
View reviewed changes
metricflow/query/group_by_item/group_by_item_resolver.py
@@ -137,13 +137,13 @@ def resolve_matching_item_for_filters(
manifest_lookup=self._manifest_lookup,
source_spec_patterns=(
spec_pattern,
BaseTimeGrainPattern(),
BaseTimeGrainPattern(only_apply_for_metric_time=True),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Validate this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@courtneyholcomb