Add Python 3.12 Support / Remove Python 3.8 Support #1066
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…date / timestamp comparison.
…n using Python 3.12.
plypaul
added
the
Run Tests With Other SQL Engines
plypaul
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
plypaul
changed the title
plypaul
force-pushed
the
plypaul--05--python-3.12
branch
from
d9cc64b to
88d9fca
Compare
plypaul
added
Run Tests With Other SQL Engines
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
github-actions
bot
removed
the
Run Tests With Other SQL Engines
plypaul
force-pushed
the
plypaul--05--python-3.12
branch
from
88d9fca to
156f081
Compare
tlento
requested changes
Mar 11, 2024
| @@ -7,7 +7,7 @@ name = "metricflow" | |||
| version = "0.205.0" | |||
| description = "Translates a simple metric definition into reusable SQL and executes it against the SQL engine of your choice." | |||
| readme = "README.md" | |||
| requires-python = ">=3.8,<3.12" | |||
| requires-python = ">=3.9,<=3.12" | |||
There was a problem hiding this comment.
Python 3.8 is supported through October, so we need to to support 3.8 through the dbt-core release following official EOL.
| @@ -33,9 +33,10 @@ dependencies = [ | |||
| "graphviz>=0.18.2, <0.21", | |||
| "halo>=0.0.31, <0.1.0", | |||
| "more-itertools>=8.10.0, <10.2.0", | |||
| "pandas>=1.5.0, <1.6.0", | |||
| # pandas 2.2 has a bug https://github.com/databricks/databricks-sql-python/issues/334, so using 2.1. | |||
| "pandas>=2.1, <2.2", | |||
There was a problem hiding this comment.
This is super restrictive, I don't think we can block 1.x installs.
Medium term I'd like to just remove pandas as a production dependency altogether, we don't need it for anything.
| "pydantic>=1.10.0, <1.11.0", | ||
| "python-dateutil>=2.8.2, <2.9.0", | ||
| "python-dateutil~=2.9.0", |
There was a problem hiding this comment.
Please don't use ~= syntax, it breaks PIP resolvers in certain edge cases.
Comment on lines
+60
to
+62
| "pytest-mock~=3.12", | ||
| "pytest-xdist~=3.5", | ||
| "pytest~=8.0", |
plypaul
changed the title
plypaul
changed the title
|
Closing this out as this was significantly revised, and related changes will be in a another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1065
Description
This PR updates the code and Github workflows to support Python 3.12.