Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for min/max with metric_time #1057

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

courtneyholcomb
Copy link
Contributor

Resolves SL-1808

Description

Resolves a #TODO that I left in here a while back. Test cases combining min/max query with metric_time only. (These features were worked on in parallel, so I couldn't add tests until they both merged.)

Copy link

linear bot commented Feb 28, 2024

@cla-bot cla-bot bot added the cla:yes label Feb 28, 2024
@courtneyholcomb courtneyholcomb marked this pull request as ready for review February 28, 2024 18:08
@courtneyholcomb courtneyholcomb added the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Feb 28, 2024
@github-actions github-actions bot removed the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Feb 28, 2024
Copy link
Contributor

@tlento tlento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@courtneyholcomb courtneyholcomb merged commit 2aa5ea5 into main Feb 28, 2024
23 checks passed
@courtneyholcomb courtneyholcomb deleted the court/min-max-metric-time-tests branch February 28, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants