Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: querying multiple granularities with offset metrics #1054

Merged
merged 10 commits into from
Feb 29, 2024
Merged

Bug fix: querying multiple granularities with offset metrics #1054

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
043d194
Changelog
courtneyholcomb Feb 28, 2024
6a39795
Write tests for existing functionality (some failing) & generate snap…
courtneyholcomb Feb 28, 2024
026b382
Update dataflow to SQL to allow multiple agg_time_dimensions
courtneyholcomb Feb 28, 2024
df5e0d9
Generate snapshots with changes
courtneyholcomb Feb 28, 2024
f4c9abd
Add order_by to output tests to ensure consistency
courtneyholcomb Feb 28, 2024
3f7d816
Update SQL engine snapshots
courtneyholcomb Feb 28, 2024
9ea7a27
Merge main
courtneyholcomb Feb 28, 2024
894b540
Merge main
courtneyholcomb Feb 29, 2024
dc60c11
Add assertion & fix variable name bug
courtneyholcomb Feb 29, 2024
89d2c2c
Update SQL engine snapshots
courtneyholcomb Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions metricflow/test/integration/query_output/test_offset_metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ def test_offset_to_grain_with_single_granularity( # noqa: D
MetricFlowQueryRequest.create_with_random_request_id(
metric_names=["bookings_at_start_of_month"],
group_by_names=["metric_time__day"],
order_by_names=["metric_time__day"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Thank you!

)
)
assert query_result.result_df is not None, "Unexpected empty result."
Expand All @@ -45,6 +46,7 @@ def test_offset_to_grain_with_multiple_granularities( # noqa: D
MetricFlowQueryRequest.create_with_random_request_id(
metric_names=["bookings_at_start_of_month"],
group_by_names=["metric_time__day", "metric_time__month", "metric_time__year"],
order_by_names=["metric_time__day", "metric_time__month", "metric_time__year"],
)
)
assert query_result.result_df is not None, "Unexpected empty result."
Expand Down
Loading