Precompute / Cache Outputs for Nodes in SourceNodeSet
#1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
approved these changes
Feb 12, 2024
| @@ -294,8 +295,10 @@ def explain_get_dimension_values( # noqa: D | |||
| """Returns the SQL query for get_dimension_values. | |||
|
|
|||
| Args: | |||
| metric_name: Names of metrics that contain the group_by. | |||
| metric_names: Names of metrics that contain the group_by. | |||
| metrics: Similar to `metric_names`, but specified via parameter objects., | |||
There was a problem hiding this comment.
nit: remove comma at the end of this line
plypaul
force-pushed
the
plypaul--88.2.1--source-node-set
branch
from
b4899bd to
a322a2d
Compare
plypaul
force-pushed
the
plypaul--88.2.2--cache-source-node-output
branch
from
5c652ff to
4e060a7
Compare
plypaul
force-pushed
the
plypaul--88.2.1--source-node-set
branch
from
a322a2d to
89a9e39
Compare
plypaul
force-pushed
the
plypaul--88.2.2--cache-source-node-output
branch
from
4e060a7 to
afe1d19
Compare
plypaul
force-pushed
the
plypaul--88.2.2--cache-source-node-output
branch
from
afe1d19 to
7840539
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When building a
DataflowPlan, nodes fromSourceNodeSetare used as common building blocks for different queries using the same semantic manifest. When the output for aDataflowPlanNodeis computed, the output is lazily computed and then cached since the output will be required many times for the same nodes (e.g. between queries, and between common join candidates). The output contains generated IDs, and so precomputing the output nodes for nodes fromSourceNodeSetwill have the following effects:DataflowPlanshould be a little more consistent between queries at the expense of initialization time.DataflowPlanBuilder.