Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Updates to MetricFlowDagTextFormatter #1027

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

plypaul
Copy link
Contributor

@plypaul plypaul commented Feb 6, 2024

Description

This PR makes some minor updates to MetricFlowDagTextFormatter:

  • Removes an unnecessary assignment.
  • Adds a multithreaded test.
  • Updates exception logging to be more helpful.

@cla-bot cla-bot bot added the cla:yes label Feb 6, 2024
Copy link

github-actions bot commented Feb 6, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@plypaul plypaul changed the title Remove Unnecessary Assignment in MetricFlowDagTextFormatter + Add Multithreaded Test Minor Updates to MetricFlowDagTextFormatter Feb 7, 2024
@plypaul plypaul marked this pull request as ready for review February 9, 2024 00:14
@plypaul plypaul force-pushed the plypaul--88.3--dag-to-text-follow-up branch from 1922d94 to 28b5c5b Compare February 13, 2024 00:55
@plypaul plypaul merged commit c585e8d into main Feb 13, 2024
9 checks passed
@plypaul plypaul deleted the plypaul--88.3--dag-to-text-follow-up branch February 13, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants