/* PR_START p--py312 16 */ Fix SQL engine label removal logic.

dbt-labs · Jun 6, 2024 · fa30148 · fa30148
1 parent 72aaec0
commit fa30148
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/.github/workflows/cd-sql-engine-tests.yaml b/.github/workflows/cd-sql-engine-tests.yaml
@@ -15,7 +15,7 @@ env:
 jobs:
   snowflake-tests:
     environment: DW_INTEGRATION_TESTS
-    if: ${{ github.event.action != 'labeled' || github.event.label.name == 'Run Tests With Other SQL Engines' }}
+    if: ${{ github.event.label.name == 'Run Tests With Other SQL Engines' }}
     name: Snowflake Tests
     runs-on: ubuntu-latest
     steps:
@@ -35,7 +35,7 @@ jobs:
   redshift-tests:
     environment: DW_INTEGRATION_TESTS
     name: Redshift Tests
-    if: ${{ github.event.action != 'labeled' || github.event.label.name == 'Run Tests With Other SQL Engines' }}
+    if: ${{ github.event.label.name == 'Run Tests With Other SQL Engines' }}
     runs-on: ubuntu-latest
     steps:
       - name: Check-out the repo
@@ -53,7 +53,7 @@ jobs:
   bigquery-tests:
     environment: DW_INTEGRATION_TESTS
     name: BigQuery Tests
-    if: ${{ github.event.action != 'labeled' || github.event.label.name == 'Run Tests With Other SQL Engines' }}
+    if: ${{ github.event.label.name == 'Run Tests With Other SQL Engines' }}
     runs-on: ubuntu-latest
     steps:
       - name: Check-out the repo
@@ -72,7 +72,7 @@ jobs:
   databricks-tests:
     environment: DW_INTEGRATION_TESTS
     name: Databricks Tests
-    if: ${{ github.event.action != 'labeled' || github.event.label.name == 'Run Tests With Other SQL Engines' }}
+    if: ${{ github.event.label.name == 'Run Tests With Other SQL Engines' }}
     runs-on: ubuntu-latest
     steps:
       - name: Check-out the repo
@@ -94,7 +94,7 @@ jobs:
     # we may choose to execute them against a hosted instance, at which point this config will look like the other
     # engine configs in this file.
     name: Trino Tests
-    if: ${{ github.event.action != 'labeled' || github.event.label.name == 'Run Tests With Other SQL Engines' }}
+    if: ${{ github.event.label.name == 'Run Tests With Other SQL Engines' }}
     runs-on: ubuntu-latest
     services:
       trino:
@@ -115,7 +115,8 @@ jobs:
     name: Remove Label After Running Tests
     runs-on: ubuntu-latest
     needs: [ snowflake-tests, redshift-tests, bigquery-tests, databricks-tests ]
-    if: github.event.action == 'labeled' && github.event.label.name == 'Run Tests With Other SQL Engines'
+    # Default behavior for `needs` is that it requires success. `always()` runs this action even if tests fail.
+    if: ${{ always() }}
     steps:
       - name: Remove Label
         uses: actions-ecosystem/action-remove-labels@v1