Skip to content

Commit

Permalink
PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
courtneyholcomb committed Oct 16, 2024
1 parent 0299f63 commit ec06c84
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion metricflow/plan_conversion/dataflow_to_sql.py
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ def _make_time_spine_data_set(

# Where constraints must be applied in an outer query since they are using an alias (e.g., 'metric_time__day'),
# and some engines do not support using an alias in the WHERE clause.
if not time_spine_where_constraints:
if len(time_spine_where_constraints) == 0:
return SqlDataSet(instance_set=output_instance_set, sql_select_node=inner_sql_select_node)

# Build outer query to apply where constraints.
Expand Down

0 comments on commit ec06c84

Please sign in to comment.