Skip to content

Commit

Permalink
Use appropriate variable name (#994)
Browse files Browse the repository at this point in the history
  • Loading branch information
courtneyholcomb authored Jan 25, 2024
1 parent 2486b4b commit e2f2ffc
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions metricflow/dataflow/builder/dataflow_plan_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -698,15 +698,15 @@ def _contains_multihop_linkables(linkable_specs: Sequence[LinkableInstanceSpec])
"""Returns true if any of the linkable specs requires a multi-hop join to realize."""
return any(len(x.entity_links) > 1 for x in linkable_specs)

def _get_semantic_model_names_for_measures(self, measure_names: Sequence[MeasureSpec]) -> Set[str]:
def _get_semantic_model_names_for_measures(self, measures: Sequence[MeasureSpec]) -> Set[str]:
"""Return the names of the semantic models needed to compute the input measures.
This is a temporary method for use in assertion boundaries while we implement support for multiple semantic models
"""
semantic_model_names: Set[str] = set()
for measure_name in measure_names:
for measure in measures:
semantic_model_names = semantic_model_names.union(
{d.name for d in self._semantic_model_lookup.get_semantic_models_for_measure(measure_name.reference)}
{d.name for d in self._semantic_model_lookup.get_semantic_models_for_measure(measure.reference)}
)
return semantic_model_names

Expand Down

0 comments on commit e2f2ffc

Please sign in to comment.