Skip to content

Commit

Permalink
Fix spelling
Browse files Browse the repository at this point in the history
  • Loading branch information
courtneyholcomb committed Sep 10, 2024
1 parent 77327f4 commit e2b274f
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def all_optimizations() -> FrozenSet[DataflowPlanOptimization]:
return frozenset((DataflowPlanOptimization.SOURCE_SCAN, DataflowPlanOptimization.PREDICATE_PUSHDOWN))

@staticmethod
def enabled_obtimizations() -> FrozenSet[DataflowPlanOptimization]:
def enabled_optimizations() -> FrozenSet[DataflowPlanOptimization]:
"""Set of DataflowPlanOptimization that are currently enabled.
Predicate pushdown optimizer is currently disabled.
Expand Down
4 changes: 2 additions & 2 deletions metricflow/engine/metricflow_engine.py
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ class MetricFlowQueryRequest:
order_by: Optional[Sequence[OrderByQueryParameter]] = None
min_max_only: bool = False
sql_optimization_level: SqlQueryOptimizationLevel = SqlQueryOptimizationLevel.O4
dataflow_plan_optimizations: FrozenSet[DataflowPlanOptimization] = DataflowPlanOptimization.enabled_obtimizations()
dataflow_plan_optimizations: FrozenSet[DataflowPlanOptimization] = DataflowPlanOptimization.enabled_optimizations()
query_type: MetricFlowQueryType = MetricFlowQueryType.METRIC

@staticmethod
Expand All @@ -130,7 +130,7 @@ def create_with_random_request_id( # noqa: D102
sql_optimization_level: SqlQueryOptimizationLevel = SqlQueryOptimizationLevel.O4,
dataflow_plan_optimizations: FrozenSet[
DataflowPlanOptimization
] = DataflowPlanOptimization.enabled_obtimizations(),
] = DataflowPlanOptimization.enabled_optimizations(),
query_type: MetricFlowQueryType = MetricFlowQueryType.METRIC,
min_max_only: bool = False,
) -> MetricFlowQueryRequest:
Expand Down
4 changes: 2 additions & 2 deletions tests_metricflow/query_rendering/compare_rendered_query.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,11 @@ def render_and_check(
# Run dataflow -> sql conversion with all optimizers
if is_distinct_values_plan:
optimized_plan = dataflow_plan_builder.build_plan_for_distinct_values(
query_spec, optimizations=DataflowPlanOptimization.enabled_obtimizations()
query_spec, optimizations=DataflowPlanOptimization.enabled_optimizations()
)
else:
optimized_plan = dataflow_plan_builder.build_plan(
query_spec, optimizations=DataflowPlanOptimization.enabled_obtimizations()
query_spec, optimizations=DataflowPlanOptimization.enabled_optimizations()
)
conversion_result = dataflow_to_sql_converter.convert_to_sql_query_plan(
sql_engine_type=sql_client.sql_engine_type,
Expand Down

0 comments on commit e2b274f

Please sign in to comment.