Skip to content

Commit

Permalink
Switch to OUTER JOIN for derived metrics
Browse files Browse the repository at this point in the history
  • Loading branch information
courtneyholcomb committed Nov 3, 2023
1 parent 151975b commit e0cb00f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion metricflow/dataflow/builder/dataflow_plan_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ def _build_metrics_output_node(
queried_linkable_specs=queried_linkable_specs,
where_constraint=where_constraint,
time_range_constraint=time_range_constraint,
combine_metrics_join_type=SqlJoinType.INNER,
combine_metrics_join_type=SqlJoinType.FULL_OUTER if MetricType.DERIVED else SqlJoinType.INNER,
),
metric_specs=[metric_spec],
)
Expand Down

0 comments on commit e0cb00f

Please sign in to comment.