Skip to content

Commit

Permalink
Fix test helpers.
Browse files Browse the repository at this point in the history
  • Loading branch information
plypaul committed Nov 13, 2024
1 parent 5f14ab2 commit dfec513
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -426,6 +426,7 @@ def assert_str_snapshot_equal( # noqa: D103
snapshot_id: str,
snapshot_str: str,
expectation_description: Optional[str] = None,
incomparable_strings_replacement_function: Optional[Callable[[str], str]] = None,
) -> None:
"""Write / compare a string snapshot."""
assert_snapshot_text_equal(
Expand All @@ -436,4 +437,5 @@ def assert_str_snapshot_equal( # noqa: D103
snapshot_text=snapshot_str,
snapshot_file_extension=".txt",
expectation_description=expectation_description,
incomparable_strings_replacement_function=incomparable_strings_replacement_function,
)
1 change: 0 additions & 1 deletion tests_metricflow/sql/compare_sql_plan.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ def assert_default_rendered_sql_equal(
) -> None:
"""Helper function to render a select statement and compare with the one saved as a file."""
sql_query_plan = SqlQueryPlan(render_node=sql_plan_node, plan_id=DagId.from_str(plan_id))

rendered_sql = DefaultSqlQueryPlanRenderer().render_sql_query_plan(sql_query_plan).sql

assert_plan_snapshot_text_equal(
Expand Down

0 comments on commit dfec513

Please sign in to comment.