Skip to content

Commit

Permalink
Clarify wording
Browse files Browse the repository at this point in the history
  • Loading branch information
courtneyholcomb committed Oct 10, 2023
1 parent ea5072c commit cc64a47
Showing 1 changed file with 9 additions and 7 deletions.
16 changes: 9 additions & 7 deletions metricflow/dataflow/builder/dataflow_plan_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -559,14 +559,16 @@ def _find_measure_recipe(

if len(node_to_evaluation) > 0:
# All source nodes cost the same. Find evaluation with lowest number of joins.
node_with_lowest_cost = min(node_to_evaluation, key=lambda node: len(node_to_evaluation[node].join_recipes))
evaluation = node_to_evaluation[node_with_lowest_cost]
node_with_lowest_cost_plan = min(
node_to_evaluation, key=lambda node: len(node_to_evaluation[node].join_recipes)
)
evaluation = node_to_evaluation[node_with_lowest_cost_plan]
logger.info(
"Lowest cost node is:\n"
"Lowest cost plan is:\n"
+ pformat_big_objects(
lowest_cost_node=dataflow_dag_as_text(node_with_lowest_cost),
node=dataflow_dag_as_text(node_with_lowest_cost_plan),
evaluation=evaluation,
joins=len(node_to_evaluation[node_with_lowest_cost].join_recipes),
joins=len(node_to_evaluation[node_with_lowest_cost_plan].join_recipes),
)
)

Expand All @@ -584,14 +586,14 @@ def _find_measure_recipe(
)

return MeasureRecipe(
measure_node=node_with_lowest_cost,
measure_node=node_with_lowest_cost_plan,
required_local_linkable_specs=(
evaluation.local_linkable_specs
+ required_local_entity_specs
+ required_local_dimension_specs
+ required_local_time_dimension_specs
),
join_linkable_instances_recipes=node_to_evaluation[node_with_lowest_cost].join_recipes,
join_linkable_instances_recipes=node_to_evaluation[node_with_lowest_cost_plan].join_recipes,
)

logger.error("No recipe could be constructed.")
Expand Down

0 comments on commit cc64a47

Please sign in to comment.