/* PR_START p--cte 07 */ Replace is_table with as_sql_table_node.

metricflow/sql/render/sql_plan_renderer.py

@@ -190,7 +190,7 @@ def _render_from_section(self, from_source: SqlQueryPlanNode, from_source_alias:
         from_render_result = self._render_node(from_source)
 
         from_section_lines = []
-        if from_source.is_table:
+        if from_source.as_sql_table_node is not None:
             from_section_lines.append(f"FROM {from_render_result.sql} {from_source_alias}")
         else:
             from_section_lines.append("FROM (")
@@ -228,7 +228,7 @@ def _render_joins_section(self, join_descriptions: Sequence[SqlJoinDescription])
                 on_condition_rendered = self.EXPR_RENDERER.render_sql_expr(join_description.on_condition)
                 params = params.merge(on_condition_rendered.bind_parameter_set)
 
-            if join_description.right_source.is_table:
+            if join_description.right_source.as_sql_table_node is not None:
                 join_section_lines.append(join_description.join_type.value)
                 join_section_lines.append(
                     textwrap.indent(

metricflow/sql/sql_plan.py

@@ -41,14 +41,14 @@ def accept(self, visitor: SqlQueryPlanNodeVisitor[VisitorOutputT]) -> VisitorOut
 
     @property
     @abstractmethod
-    def is_table(self) -> bool:
-        """Returns whether this node resolves to a table (vs. a query)."""
+    def as_select_node(self) -> Optional[SqlSelectStatementNode]:
+        """If possible, return this as a select statement node."""
         raise NotImplementedError
 
     @property
     @abstractmethod
-    def as_select_node(self) -> Optional[SqlSelectStatementNode]:
-        """If possible, return this as a select statement node."""
+    def as_sql_table_node(self) -> Optional[SqlTableNode]:
+        """If possible, return this as SQL table node."""
         raise NotImplementedError
 
 
@@ -192,14 +192,15 @@ def displayed_properties(self) -> Sequence[DisplayedProperty]:  # noqa: D102
     def accept(self, visitor: SqlQueryPlanNodeVisitor[VisitorOutputT]) -> VisitorOutputT:  # noqa: D102
         return visitor.visit_select_statement_node(self)
 
-    @property
-    def is_table(self) -> bool:  # noqa: D102
-        return False
-
     @property
     def as_select_node(self) -> Optional[SqlSelectStatementNode]:  # noqa: D102
         return self
 
+    @property
+    @override
+    def as_sql_table_node(self) -> Optional[SqlTableNode]:
+        return None
+
     @property
     @override
     def description(self) -> str:
@@ -234,14 +235,15 @@ def displayed_properties(self) -> Sequence[DisplayedProperty]:  # noqa: D102
     def accept(self, visitor: SqlQueryPlanNodeVisitor[VisitorOutputT]) -> VisitorOutputT:  # noqa: D102
         return visitor.visit_table_node(self)
 
-    @property
-    def is_table(self) -> bool:  # noqa: D102
-        return True
-
     @property
     def as_select_node(self) -> Optional[SqlSelectStatementNode]:  # noqa: D102
         return None
 
+    @property
+    @override
+    def as_sql_table_node(self) -> Optional[SqlTableNode]:
+        return self
+
 
 @dataclass(frozen=True, eq=False)
 class SqlSelectQueryFromClauseNode(SqlQueryPlanNode):
@@ -272,11 +274,12 @@ def accept(self, visitor: SqlQueryPlanNodeVisitor[VisitorOutputT]) -> VisitorOut
         return visitor.visit_query_from_clause_node(self)
 
     @property
-    def is_table(self) -> bool:  # noqa: D102
-        return False
+    def as_select_node(self) -> Optional[SqlSelectStatementNode]:  # noqa: D102
+        return None
 
+    @override
     @property
-    def as_select_node(self) -> Optional[SqlSelectStatementNode]:  # noqa: D102
+    def as_sql_table_node(self) -> Optional[SqlTableNode]:
         return None
 
 
@@ -286,7 +289,6 @@ class SqlCreateTableAsNode(SqlQueryPlanNode):
 
     Attributes:
         sql_table: The SQL table to create.
-        parent_node: The parent query plan node.
     """
 
     sql_table: SqlTable
@@ -308,12 +310,12 @@ def accept(self, visitor: SqlQueryPlanNodeVisitor[VisitorOutputT]) -> VisitorOut
 
     @property
     @override
-    def is_table(self) -> bool:
-        return False
+    def as_select_node(self) -> Optional[SqlSelectStatementNode]:
+        return None
 
     @property
     @override
-    def as_select_node(self) -> Optional[SqlSelectStatementNode]:
+    def as_sql_table_node(self) -> Optional[SqlTableNode]:
         return None
 
     @property
@@ -356,11 +358,11 @@ def render_node(self) -> SqlQueryPlanNode:  # noqa: D102
 class SqlCteNode(SqlQueryPlanNode):
     """Represents a single common table expression."""
 
-    select_statement: SqlSelectStatementNode
+    select_statement: SqlQueryPlanNode
     cte_alias: str
 
     @staticmethod
-    def create(select_statement: SqlSelectStatementNode, cte_alias: str) -> SqlCteNode:  # noqa: D102
+    def create(select_statement: SqlQueryPlanNode, cte_alias: str) -> SqlCteNode:  # noqa: D102
         return SqlCteNode(
             parent_nodes=(select_statement,),
             select_statement=select_statement,
@@ -373,12 +375,12 @@ def accept(self, visitor: SqlQueryPlanNodeVisitor[VisitorOutputT]) -> VisitorOut
 
     @property
     @override
-    def is_table(self) -> bool:
-        return False
+    def as_select_node(self) -> Optional[SqlSelectStatementNode]:
+        return None
 
     @property
     @override
-    def as_select_node(self) -> Optional[SqlSelectStatementNode]:
+    def as_sql_table_node(self) -> Optional[SqlTableNode]:
         return None
 
     @property