Skip to content

Commit

Permalink
Update docstring for visit_combine_metrics_node
Browse files Browse the repository at this point in the history
  • Loading branch information
courtneyholcomb committed Nov 4, 2023
1 parent dbb8a2f commit b243aad
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions metricflow/plan_conversion/dataflow_to_sql.py
Original file line number Diff line number Diff line change
Expand Up @@ -906,12 +906,10 @@ def visit_combine_metrics_node(self, node: CombineMetricsNode) -> SqlDataSet:
"""Join computed metric datasets together to return a single dataset containing all metrics.
This node may exist in one of two situations: when metrics need to be combined in order to produce a single
dataset with all required inputs for a derived metric (in which case the join type is INNER), or when
metrics need to be combined in order to produce a single dataset of output for downstream consumption by
the end user, in which case we will use FULL OUTER JOIN.
dataset with all required inputs for a derived metric, or when metrics need to be combined in order to produce
a single dataset of output for downstream consumption by the end user.
In the case of a multi-data-source FULL OUTER JOIN the join key will be a coalesced set of all previously
seen dimension values. For example:
The join key will be a coalesced set of all previously seen dimension values. For example:
FROM (
...
) subq_9
Expand Down

0 comments on commit b243aad

Please sign in to comment.