Comment

dbt-labs · Nov 10, 2023 · a9a1527 · a9a1527
1 parent f0837c6
commit a9a1527
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/metricflow/dataflow/builder/dataflow_plan_builder.py b/metricflow/dataflow/builder/dataflow_plan_builder.py
@@ -614,7 +614,8 @@ def _find_dataflow_recipe(
 
         # Dict from the node that contains the source node to the evaluation results.
         node_to_evaluation: Dict[BaseOutput, LinkableInstanceSatisfiabilityEvaluation] = {}
-
+        # If only dimensions, and one is metric_time, will require cross-join!
+        # If only dimensions, will require full outer join!
         for node in self._sort_by_suitability(potential_source_nodes):
             data_set = self._node_data_set_resolver.get_output_data_set(node)