Skip to content

Commit

Permalink
Add test for just listing - same error
Browse files Browse the repository at this point in the history
  • Loading branch information
courtneyholcomb committed May 12, 2024
1 parent f256561 commit a7227f1
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 1 deletion.
14 changes: 14 additions & 0 deletions tests_metricflow/integration/test_cases/itest_dimensions.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -373,3 +373,17 @@ integration_test:
) outer_subq
WHERE listing__bookings > 2
GROUP BY listing
---
integration_test:
name: just_listings
description: Query without metrics using a metric filter
model: SIMPLE_MODEL
group_bys: ["listing"]
# I don't see how you could specify you want listing from the listings_latest source
check_query: |
SELECT
listing_id AS listing
FROM {{ source_schema }}.dim_lux_listing_id_mapping l
GROUP BY
listing_id
3 changes: 2 additions & 1 deletion tests_metricflow/integration/test_configured_cases.py
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ def filter_not_supported_features(
@pytest.mark.parametrize(
"name",
# CONFIGURED_INTEGRATION_TESTS_REPOSITORY.all_test_case_names,
["itest_dimensions.yaml/distinct_values_query_with_metric_filter"],
["itest_dimensions.yaml/just_listings"],
ids=lambda name: f"name={name}",
)
def test_case(
Expand Down Expand Up @@ -338,6 +338,7 @@ def test_case(
)

actual = query_result.result_df
# assert 0, query_result.sql

expected = sql_client.query(
jinja2.Template(
Expand Down

0 comments on commit a7227f1

Please sign in to comment.