Skip to content

Commit

Permalink
Bug fix: Use base grain when filtering elements for conversion metric…
Browse files Browse the repository at this point in the history
…s pre-aggregation
  • Loading branch information
courtneyholcomb committed Oct 23, 2024
1 parent 30c09b6 commit a5e58be
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion metricflow/dataflow/builder/dataflow_plan_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ def _build_aggregated_conversion_node(
filtered_unaggregated_base_node = FilterElementsNode.create(
parent_node=unaggregated_base_measure_node,
include_specs=group_specs_by_type(required_local_specs)
.merge(InstanceSpecSet.create_from_specs(base_required_linkable_specs.as_tuple))
.merge(base_measure_recipe.all_linkable_specs_required_for_source_nodes.as_instance_spec_set)
.dedupe(),
)

Expand Down

0 comments on commit a5e58be

Please sign in to comment.