Skip to content

Commit

Permalink
Update snapshots to reflect spec changes / test updates.
Browse files Browse the repository at this point in the history 
TODO: Fix duplication for repeated filters.
  • Loading branch information
@plypaul
plypaul committed Nov 30, 2023
1 parent 92c5191 commit a13928a
Show file tree
Hide file tree
Showing 73 changed files with 343 additions and 331 deletions.
2 changes: 1 addition & 1 deletion metricflow/test/snapshots/test_cyclic_join.py/DataflowPlan/test_cyclic_join__dfp_0.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<!-- metric_spec = -->
<!-- {'class': 'MetricSpec', -->
<!-- 'element_name': 'listings', -->
<!-- 'constraint': None, -->
<!-- 'filter_specs': (), -->
<!-- 'alias': None, -->
<!-- 'offset_window': None, -->
<!-- 'offset_to_grain': None} -->
Expand Down
4 changes: 2 additions & 2 deletions ...napshots/test_dataflow_plan_builder.py/DataflowPlan/test_common_semantic_model__dfp_0.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<!-- metric_spec = -->
<!-- {'class': 'MetricSpec', -->
<!-- 'element_name': 'bookings', -->
<!-- 'constraint': None, -->
<!-- 'filter_specs': (), -->
<!-- 'alias': None, -->
<!-- 'offset_window': None, -->
<!-- 'offset_to_grain': None} -->
Expand Down Expand Up @@ -117,7 +117,7 @@
<!-- metric_spec = -->
<!-- {'class': 'MetricSpec', -->
<!-- 'element_name': 'booking_value', -->
<!-- 'constraint': None, -->
<!-- 'filter_specs': (), -->
<!-- 'alias': None, -->
<!-- 'offset_window': None, -->
<!-- 'offset_to_grain': None} -->
Expand Down
2 changes: 1 addition & 1 deletion ...der.py/DataflowPlan/test_cumulative_metric_no_window_or_grain_with_metric_time__dfp_0.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<!-- metric_spec = -->
<!-- {'class': 'MetricSpec', -->
<!-- 'element_name': 'revenue_all_time', -->
<!-- 'constraint': None, -->
<!-- 'filter_specs': (), -->
<!-- 'alias': None, -->
<!-- 'offset_window': None, -->
<!-- 'offset_to_grain': None} -->
Expand Down
2 changes: 1 addition & 1 deletion ....py/DataflowPlan/test_cumulative_metric_no_window_or_grain_without_metric_time__dfp_0.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<!-- metric_spec = -->
<!-- {'class': 'MetricSpec', -->
<!-- 'element_name': 'revenue_all_time', -->
<!-- 'constraint': None, -->
<!-- 'filter_specs': (), -->
<!-- 'alias': None, -->
<!-- 'offset_window': None, -->
<!-- 'offset_to_grain': None} -->
Expand Down
2 changes: 1 addition & 1 deletion .../test_dataflow_plan_builder.py/DataflowPlan/test_cumulative_metric_with_window__dfp_0.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<!-- metric_spec = -->
<!-- {'class': 'MetricSpec', -->
<!-- 'element_name': 'trailing_2_months_revenue', -->
<!-- 'constraint': None, -->
<!-- 'filter_specs': (), -->
<!-- 'alias': None, -->
<!-- 'offset_window': None, -->
<!-- 'offset_to_grain': None} -->
Expand Down
6 changes: 3 additions & 3 deletions ...test_dataflow_plan_builder.py/DataflowPlan/test_derived_metric_offset_to_grain__dfp_0.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<!-- metric_spec = -->
<!-- {'class': 'MetricSpec', -->
<!-- 'element_name': 'bookings_growth_since_start_of_month', -->
<!-- 'constraint': None, -->
<!-- 'filter_specs': (), -->
<!-- 'alias': None, -->
<!-- 'offset_window': None, -->
<!-- 'offset_to_grain': None} -->
Expand All @@ -21,7 +21,7 @@
<!-- metric_spec = -->
<!-- {'class': 'MetricSpec', -->
<!-- 'element_name': 'bookings', -->
<!-- 'constraint': None, -->
<!-- 'filter_specs': (), -->
<!-- 'alias': None, -->
<!-- 'offset_window': None, -->
<!-- 'offset_to_grain': None} -->
Expand Down Expand Up @@ -67,7 +67,7 @@
<!-- metric_spec = -->
<!-- {'class': 'MetricSpec', -->
<!-- 'element_name': 'bookings', -->
<!-- 'constraint': None, -->
<!-- 'filter_specs': (), -->
<!-- 'alias': 'bookings_at_start_of_month', -->
<!-- 'offset_window': None, -->
<!-- 'offset_to_grain': TimeGranularity.MONTH} -->
Expand Down
4 changes: 2 additions & 2 deletions ...s/test_dataflow_plan_builder.py/DataflowPlan/test_derived_metric_offset_window__dfp_0.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<!-- metric_spec = -->
<!-- {'class': 'MetricSpec', -->
<!-- 'element_name': 'bookings_5_day_lag', -->
<!-- 'constraint': None, -->
<!-- 'filter_specs': (), -->
<!-- 'alias': None, -->
<!-- 'offset_window': None, -->
<!-- 'offset_to_grain': None} -->
Expand All @@ -18,7 +18,7 @@
<!-- metric_spec = -->
<!-- {'class': 'MetricSpec', -->
<!-- 'element_name': 'bookings', -->
<!-- 'constraint': None, -->
<!-- 'filter_specs': (), -->
<!-- 'alias': 'bookings_5_days_ago', -->
<!-- 'offset_window': {'class': 'PydanticMetricTimeWindow', -->
<!-- 'count': 5, -->
Expand Down
4 changes: 2 additions & 2 deletions ...aflow_plan_builder.py/DataflowPlan/test_derived_metric_offset_with_granularity__dfp_0.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<!-- metric_spec = -->
<!-- {'class': 'MetricSpec', -->
<!-- 'element_name': 'bookings_5_day_lag', -->
<!-- 'constraint': None, -->
<!-- 'filter_specs': (), -->
<!-- 'alias': None, -->
<!-- 'offset_window': None, -->
<!-- 'offset_to_grain': None} -->
Expand All @@ -18,7 +18,7 @@
<!-- metric_spec = -->
<!-- {'class': 'MetricSpec', -->
<!-- 'element_name': 'bookings', -->
<!-- 'constraint': None, -->
<!-- 'filter_specs': (), -->
<!-- 'alias': 'bookings_5_days_ago', -->
<!-- 'offset_window': {'class': 'PydanticMetricTimeWindow', -->
<!-- 'count': 5, -->
Expand Down
4 changes: 2 additions & 2 deletions ...st_dataflow_plan_builder.py/DataflowPlan/test_derived_offset_cumulative_metric__dfp_0.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<!-- metric_spec = -->
<!-- {'class': 'MetricSpec', -->
<!-- 'element_name': 'every_2_days_bookers_2_days_ago', -->
<!-- 'constraint': None, -->
<!-- 'filter_specs': (), -->
<!-- 'alias': None, -->
<!-- 'offset_window': None, -->
<!-- 'offset_to_grain': None} -->
Expand All @@ -18,7 +18,7 @@
<!-- metric_spec = -->
<!-- {'class': 'MetricSpec', -->
<!-- 'element_name': 'every_two_days_bookers', -->
<!-- 'constraint': None, -->
<!-- 'filter_specs': (), -->
<!-- 'alias': 'every_2_days_bookers_2_days_ago', -->
<!-- 'offset_window': {'class': 'PydanticMetricTimeWindow', -->
<!-- 'count': 2, -->
Expand Down
4 changes: 2 additions & 2 deletions ...test_dataflow_plan_builder.py/DataflowPlan/test_distinct_values_plan_with_join__dfp_0.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@
<!-- description = Write to Dataframe -->
<!-- node_id = wrd_0 -->
<OrderByLimitNode>
<!-- description = Order By ['listing__country_latest'] Limit 100 -->
<!-- description = Order By ['listing__is_lux_latest'] Limit 100 -->
<!-- node_id = obl_0 -->
<!-- order_by_spec = -->
<!-- {'class': 'OrderBySpec', -->
<!-- 'instance_spec': {'class': 'DimensionSpec', -->
<!-- 'element_name': 'country_latest', -->
<!-- 'element_name': 'is_lux_latest', -->
<!-- 'entity_links': ({'class': 'EntityReference', -->
<!-- 'element_name': 'listing'},)}, -->
<!-- 'descending': True} -->
Expand Down
2 changes: 1 addition & 1 deletion ...er.py/DataflowPlan/test_dont_join_to_time_spine_if_no_time_dimension_requested__dfp_0.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<!-- metric_spec = -->
<!-- {'class': 'MetricSpec', -->
<!-- 'element_name': 'bookings_fill_nulls_with_0', -->
<!-- 'constraint': None, -->
<!-- 'filter_specs': (), -->
<!-- 'alias': None, -->
<!-- 'offset_window': None, -->
<!-- 'offset_to_grain': None} -->
Expand Down
6 changes: 3 additions & 3 deletions ...t_dataflow_plan_builder.py/DataflowPlan/test_join_to_time_spine_derived_metric__dfp_0.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<!-- metric_spec = -->
<!-- {'class': 'MetricSpec', -->
<!-- 'element_name': 'bookings_growth_2_weeks_fill_nulls_with_0', -->
<!-- 'constraint': None, -->
<!-- 'filter_specs': (), -->
<!-- 'alias': None, -->
<!-- 'offset_window': None, -->
<!-- 'offset_to_grain': None} -->
Expand All @@ -21,7 +21,7 @@
<!-- metric_spec = -->
<!-- {'class': 'MetricSpec', -->
<!-- 'element_name': 'bookings_fill_nulls_with_0', -->
<!-- 'constraint': None, -->
<!-- 'filter_specs': (), -->
<!-- 'alias': None, -->
<!-- 'offset_window': None, -->
<!-- 'offset_to_grain': None} -->
Expand Down Expand Up @@ -82,7 +82,7 @@
<!-- metric_spec = -->
<!-- {'class': 'MetricSpec', -->
<!-- 'element_name': 'bookings_fill_nulls_with_0', -->
<!-- 'constraint': None, -->
<!-- 'filter_specs': (), -->
<!-- 'alias': 'bookings_2_weeks_ago', -->
<!-- 'offset_window': {'class': 'PydanticMetricTimeWindow', -->
<!-- 'count': 14, -->
Expand Down
2 changes: 1 addition & 1 deletion ...dataflow_plan_builder.py/DataflowPlan/test_join_to_time_spine_with_metric_time__dfp_0.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<!-- metric_spec = -->
<!-- {'class': 'MetricSpec', -->
<!-- 'element_name': 'bookings_fill_nulls_with_0', -->
<!-- 'constraint': None, -->
<!-- 'filter_specs': (), -->
<!-- 'alias': None, -->
<!-- 'offset_window': None, -->
<!-- 'offset_to_grain': None} -->
Expand Down
2 changes: 1 addition & 1 deletion ...flow_plan_builder.py/DataflowPlan/test_join_to_time_spine_with_non_metric_time__dfp_0.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<!-- metric_spec = -->
<!-- {'class': 'MetricSpec', -->
<!-- 'element_name': 'bookings_fill_nulls_with_0', -->
<!-- 'constraint': None, -->
<!-- 'filter_specs': (), -->
<!-- 'alias': None, -->
<!-- 'offset_window': None, -->
<!-- 'offset_to_grain': None} -->
Expand Down
2 changes: 1 addition & 1 deletion ...low/test/snapshots/test_dataflow_plan_builder.py/DataflowPlan/test_joined_plan__dfp_0.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<!-- metric_spec = -->
<!-- {'class': 'MetricSpec', -->
<!-- 'element_name': 'bookings', -->
<!-- 'constraint': None, -->
<!-- 'filter_specs': (), -->
<!-- 'alias': None, -->
<!-- 'offset_window': None, -->
<!-- 'offset_to_grain': None} -->
Expand Down
2 changes: 1 addition & 1 deletion ...test/snapshots/test_dataflow_plan_builder.py/DataflowPlan/test_limit_rows_plan__dfp_0.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<!-- metric_spec = -->
<!-- {'class': 'MetricSpec', -->
<!-- 'element_name': 'bookings', -->
<!-- 'constraint': None, -->
<!-- 'filter_specs': (), -->
<!-- 'alias': None, -->
<!-- 'offset_window': None, -->
<!-- 'offset_to_grain': None} -->
Expand Down
Loading

0 comments on commit a13928a

Please sign in to comment.