Add test for filtering by the same metric you're querying

metricflow/model/semantics/linkable_spec_resolver.py

@@ -635,7 +635,6 @@ def _get_joinable_metrics_for_semantic_model(
                 f"Got semantic model: {semantic_model.reference.semantic_model_name}; "
                 f"last join path element: {using_join_path.last_semantic_model_reference.semantic_model_name}",
             )
-            # TODO: confirm that this is what we internally consider multi-hop
             properties = properties.union(frozenset({LinkableElementProperty.MULTI_HOP}))
 
         path_key_to_linkable_metrics: Dict[ElementPathKey, Tuple[LinkableMetric, ...]] = {}

tests/query_rendering/test_metric_filter_rendering.py

@@ -229,4 +229,28 @@ def test_distinct_values_query_with_metric_filter(
     )
 
 
-# TODO: tests for filters with conversion metrics
+@pytest.mark.sql_engine_snapshot
+def test_metric_filtered_by_itself(
+    request: FixtureRequest,
+    mf_test_configuration: MetricFlowTestConfiguration,
+    dataflow_plan_builder: DataflowPlanBuilder,
+    sql_client: SqlClient,
+    dataflow_to_sql_converter: DataflowToSqlQueryPlanConverter,
+    query_parser: MetricFlowQueryParser,
+) -> None:
+    """Tests a query for a metric that filters by the same metric."""
+    query_spec = query_parser.parse_and_validate_query(
+        metric_names=("bookers",),
+        where_constraint=PydanticWhereFilter(
+            where_sql_template="{{ Metric('bookers', ['guest']) }} > 1.00",
+        ),
+    )
+    dataflow_plan = dataflow_plan_builder.build_plan(query_spec)
+
+    convert_and_check(
+        request=request,
+        mf_test_configuration=mf_test_configuration,
+        dataflow_to_sql_converter=dataflow_to_sql_converter,
+        sql_client=sql_client,
+        node=dataflow_plan.sink_output_nodes[0].parent_node,
+    )