Skip to content

Commit

Permalink
Remove TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
courtneyholcomb committed Oct 31, 2023
1 parent 79b12a4 commit 7b54e38
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion metricflow/dataflow/builder/dataflow_plan_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -924,7 +924,6 @@ def _build_aggregated_measures_from_measure_source_node(
break

# TODO: if multiple measures and only some join to time spine, should we aggregate separately?
# TODO: what is time range constraint here? does it need to be smaller?
# Only join to time spine if metric time was requested in the query.
if join_aggregated_measure_to_time_spine and metric_time_dimension_requested:
return JoinToTimeSpineNode(
Expand Down

0 comments on commit 7b54e38

Please sign in to comment.