Skip to content

Commit

Permalink
Handle TODO - validate min_max_only isn't used for metric queries
Browse files Browse the repository at this point in the history
  • Loading branch information
courtneyholcomb committed Aug 13, 2024
1 parent 76ac912 commit 6e84206
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,8 @@ def _parse_and_validate_query(
order_by: Optional[Sequence[OrderByQueryParameter]],
min_max_only: bool,
) -> ParseQueryResult:
# TODO: validate min_max_only - can only be called for non-metric queries
if min_max_only and (metric_names or metrics):
raise InvalidQueryException("Cannot use min_max_only param for queries with metrics.")
assert_at_most_one_arg_set(metric_names=metric_names, metrics=metrics)
assert_at_most_one_arg_set(group_by_names=group_by_names, group_by=group_by)
assert_at_most_one_arg_set(order_by_names=order_by_names, order_by=order_by)
Expand Down

0 comments on commit 6e84206

Please sign in to comment.