Rename node visitor method to match typical pattern (#1121)

dbt-labs · Apr 10, 2024 · 66b030a · 66b030a
1 parent 94ead4c
commit 66b030a
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/metricflow/dataflow/dataflow_plan.py b/metricflow/dataflow/dataflow_plan.py
@@ -127,7 +127,7 @@ def visit_write_to_result_table_node(self, node: WriteToResultTableNode) -> Visi
         pass
 
     @abstractmethod
-    def visit_pass_elements_filter_node(self, node: FilterElementsNode) -> VisitorOutputT:  # noqa: D102
+    def visit_filter_elements_node(self, node: FilterElementsNode) -> VisitorOutputT:  # noqa: D102
         pass
 
     @abstractmethod

diff --git a/metricflow/dataflow/nodes/filter_elements.py b/metricflow/dataflow/nodes/filter_elements.py
@@ -41,7 +41,7 @@ def distinct(self) -> bool:
         return self._distinct
 
     def accept(self, visitor: DataflowPlanNodeVisitor[VisitorOutputT]) -> VisitorOutputT:  # noqa: D102
-        return visitor.visit_pass_elements_filter_node(self)
+        return visitor.visit_filter_elements_node(self)
 
     @property
     def description(self) -> str:  # noqa: D102

diff --git a/metricflow/dataflow/optimizer/source_scan/cm_branch_combiner.py b/metricflow/dataflow/optimizer/source_scan/cm_branch_combiner.py
@@ -338,7 +338,7 @@ def visit_write_to_result_table_node(  # noqa: D102
         self._log_visit_node_type(node)
         return self._handle_unsupported_node(node)
 
-    def visit_pass_elements_filter_node(  # noqa: D102
+    def visit_filter_elements_node(  # noqa: D102
         self, node: FilterElementsNode
     ) -> ComputeMetricsBranchCombinerResult:  # noqa: D102
         self._log_visit_node_type(node)

diff --git a/metricflow/dataflow/optimizer/source_scan/source_scan_optimizer.py b/metricflow/dataflow/optimizer/source_scan/source_scan_optimizer.py
@@ -194,7 +194,7 @@ def visit_write_to_result_table_node(self, node: WriteToResultTableNode) -> Opti
         self._log_visit_node_type(node)
         return self._default_sink_node_handler(node)
 
-    def visit_pass_elements_filter_node(self, node: FilterElementsNode) -> OptimizeBranchResult:  # noqa: D102
+    def visit_filter_elements_node(self, node: FilterElementsNode) -> OptimizeBranchResult:  # noqa: D102
         self._log_visit_node_type(node)
         return self._default_base_output_handler(node)
 

diff --git a/metricflow/plan_conversion/dataflow_to_sql.py b/metricflow/plan_conversion/dataflow_to_sql.py
@@ -828,7 +828,7 @@ def visit_write_to_result_table_node(self, node: WriteToResultTableNode) -> SqlD
             ),
         )
 
-    def visit_pass_elements_filter_node(self, node: FilterElementsNode) -> SqlDataSet:
+    def visit_filter_elements_node(self, node: FilterElementsNode) -> SqlDataSet:
         """Generates the query that realizes the behavior of FilterElementsNode."""
         from_data_set: SqlDataSet = node.parent_node.accept(self)
         output_instance_set = from_data_set.instance_set.transform(FilterElements(node.include_specs))

diff --git a/tests/dataflow/optimizer/source_scan/test_source_scan_optimizer.py b/tests/dataflow/optimizer/source_scan/test_source_scan_optimizer.py
@@ -78,7 +78,7 @@ def visit_write_to_result_dataframe_node(self, node: WriteToResultDataframeNode)
     def visit_write_to_result_table_node(self, node: WriteToResultTableNode) -> int:  # noqa: D102
         return self._sum_parents(node)
 
-    def visit_pass_elements_filter_node(self, node: FilterElementsNode) -> int:  # noqa: D102
+    def visit_filter_elements_node(self, node: FilterElementsNode) -> int:  # noqa: D102
         return self._sum_parents(node)
 
     def visit_combine_aggregated_outputs_node(self, node: CombineAggregatedOutputsNode) -> int:  # noqa: D102