Feedback: use Sequence type

dbt-labs · Dec 9, 2024 · 657993f · 657993f
1 parent 2ae5cde
commit 657993f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/metricflow-semantics/metricflow_semantics/instances.py b/metricflow-semantics/metricflow_semantics/instances.py
@@ -145,10 +145,10 @@ def with_entity_prefix(
             spec=transformed_spec,
         )
 
-    def with_new_defined_from(self, defined_from: Tuple[SemanticModelElementReference, ...]) -> TimeDimensionInstance:
+    def with_new_defined_from(self, defined_from: Sequence[SemanticModelElementReference]) -> TimeDimensionInstance:
         """Returns a new instance with the defined_from field replaced."""
         return TimeDimensionInstance(
-            associated_columns=self.associated_columns, defined_from=defined_from, spec=self.spec
+            associated_columns=self.associated_columns, defined_from=tuple(defined_from), spec=self.spec
         )
 
 

diff --git a/metricflow-semantics/metricflow_semantics/specs/time_dimension_spec.py b/metricflow-semantics/metricflow_semantics/specs/time_dimension_spec.py
@@ -246,7 +246,7 @@ def with_entity_prefix(self, entity_prefix: EntityReference) -> TimeDimensionSpe
         )
 
     @staticmethod
-    def with_base_grains(time_dimension_specs: Sequence[TimeDimensionSpec]) -> List[TimeDimensionSpec]:
+    def with_base_grains(time_dimension_specs: Sequence[TimeDimensionSpec]) -> Sequence[TimeDimensionSpec]:
         """Return the list of time dimension specs, replacing any custom grains with base grains.
 
         Dedupes new specs, but preserves the initial order.