Skip to content

Commit

Permalink
Stop triggering SQL Engine Tests on push to main
Browse files Browse the repository at this point in the history
This GitHub Action requires manual approval to run in order to
protect the various warehouse credentials included in it.

However, we trigger it on every push to main, and those nearly
always go without approval. In practice, these tests are only
run manually, either via a PR label or the occasional "I want
to run these on trunk so I'll approve the last one of these that
triggered off a push to main".

We can do the latter via workflow_dispatch anyway, so let's just
get rid of the nearly-universally-ignored action trigger.
  • Loading branch information
tlento committed Jan 20, 2024
1 parent 4b42c5f commit 52d8f62
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/cd-sql-engine-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ name: MetricFlow SQL Engine Tests

on:
workflow_dispatch:
push:
branches:
- main
pull_request:
types: [labeled]

Expand Down

0 comments on commit 52d8f62

Please sign in to comment.