Add NoGroupByMetricPattern

GroupByMetrics are allowed in filters, but not in group by items. Use new pattern to distinguish the two.

metricflow-semantics/metricflow_semantics/query/group_by_item/group_by_item_resolver.py

@@ -28,6 +28,7 @@
 )
 from metricflow_semantics.query.suggestion_generator import QueryItemSuggestionGenerator
 from metricflow_semantics.specs.patterns.base_time_grain import BaseTimeGrainPattern
+from metricflow_semantics.specs.patterns.no_group_by_metric import NoGroupByMetricPattern
 from metricflow_semantics.specs.patterns.spec_pattern import SpecPattern
 from metricflow_semantics.specs.patterns.typed_patterns import TimeDimensionPattern
 from metricflow_semantics.specs.spec_classes import LinkableInstanceSpec
@@ -87,7 +88,7 @@ def resolve_matching_item_for_querying(
         """
         push_down_visitor = _PushDownGroupByItemCandidatesVisitor(
             manifest_lookup=self._manifest_lookup,
-            source_spec_patterns=(spec_pattern,),
+            source_spec_patterns=(spec_pattern, NoGroupByMetricPattern()),
             suggestion_generator=suggestion_generator,
         )
 
@@ -146,15 +147,12 @@ def resolve_matching_item_for_filters(
         suggestion_generator = QueryItemSuggestionGenerator(
             input_naming_scheme=ObjectBuilderNamingScheme(),
             input_str=input_str,
-            candidate_filters=QueryItemSuggestionGenerator.GROUP_BY_ITEM_CANDIDATE_FILTERS,
+            candidate_filters=QueryItemSuggestionGenerator.FILTER_ITEM_CANDIDATE_FILTERS,
         )
 
         push_down_visitor = _PushDownGroupByItemCandidatesVisitor(
             manifest_lookup=self._manifest_lookup,
-            source_spec_patterns=(
-                spec_pattern,
-                BaseTimeGrainPattern(),
-            ),
+            source_spec_patterns=(spec_pattern, BaseTimeGrainPattern()),
             suggestion_generator=suggestion_generator,
         )
 

metricflow-semantics/metricflow_semantics/specs/patterns/no_group_by_metric.py

@@ -0,0 +1,29 @@
+from __future__ import annotations
+
+from typing import List, Sequence
+
+from typing_extensions import override
+
+from metricflow_semantics.specs.patterns.spec_pattern import SpecPattern
+from metricflow_semantics.specs.spec_classes import (
+    InstanceSpec,
+    LinkableInstanceSpec,
+)
+from metricflow_semantics.specs.spec_set import group_specs_by_type
+
+
+class NoGroupByMetricPattern(SpecPattern):
+    """Matches to linkable specs, but only if they're not group by metrics.
+
+    Group by metrics are allowed in filters but not in the query input group by.
+    """
+
+    @override
+    def match(self, candidate_specs: Sequence[InstanceSpec]) -> Sequence[LinkableInstanceSpec]:
+        specs_to_return: List[LinkableInstanceSpec] = []
+        spec_set = group_specs_by_type(candidate_specs)
+        specs_to_return.extend(spec_set.time_dimension_specs)
+        specs_to_return.extend(spec_set.dimension_specs)
+        specs_to_return.extend(spec_set.entity_specs)
+
+        return specs_to_return