Skip to content

Commit

Permalink
Address comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
plypaul committed May 15, 2024
1 parent d21f55b commit 488e029
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -220,13 +220,6 @@ def metric_reference(self) -> MetricReference: # noqa: D102
def reference(self) -> GroupByMetricReference: # noqa: D102
return GroupByMetricReference(self.metric_reference.element_name)

@property
def join_by_semantic_model(self) -> Optional[SemanticModelReference]: # noqa: D102
if len(self.join_path.semantic_model_join_path.path_elements) == 0:
return None

return self.join_path.semantic_model_join_path.last_semantic_model_reference

@property
@override
def derived_from_semantic_models(self) -> Sequence[SemanticModelReference]:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,7 @@ def get_joinable_metrics_for_semantic_model(
f"last join path element: {using_join_path.last_semantic_model_reference.semantic_model_name}",
)
# Temp: disable LinkableMetrics with outer join path until there is an interface to specify it.
# The result's properties = properties.union(frozenset({LinkableElementProperty.MULTI_HOP}))
return LinkableElementSet()

path_key_to_linkable_metrics: Dict[ElementPathKey, Tuple[LinkableMetric, ...]] = {}
Expand Down

0 comments on commit 488e029

Please sign in to comment.