Use new YAML field name + skip broken test

dbt-labs · Jul 13, 2024 · 454613d · 454613d
1 parent 8666f5c
commit 454613d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/...cs/metricflow_semantics/test_helpers/semantic_manifest_yamls/simple_manifest/metrics.yaml b/...cs/metricflow_semantics/test_helpers/semantic_manifest_yamls/simple_manifest/metrics.yaml
@@ -114,7 +114,7 @@ metric:
   type: simple
   type_params:
     measure: largest_listing
-  default_granularity: month
+  time_granularity: month
 ---
 metric:
   name: "identity_verifications"
@@ -627,7 +627,7 @@ metric:
       name: bookings
       join_to_timespine: true
       fill_nulls_with: 0
-  default_granularity: week
+  time_granularity: week
 ---
 metric:
   name: every_two_days_bookers_fill_nulls_with_0
@@ -782,4 +782,4 @@ metric:
     denominator:
       name: listings
   filter: "{{ Metric('views', ['listing']) }} > 10"
-  default_granularity: week
+  time_granularity: week
diff --git a/metricflow-semantics/tests_metricflow_semantics/query/test_query_parser.py b/metricflow-semantics/tests_metricflow_semantics/query/test_query_parser.py
@@ -85,7 +85,7 @@
       type_params:
         measure: bookings
       filter: "{{ Dimension('booking__is_instant') }}"
-      default_granularity: year
+      time_granularity: year
     ---
     metric:
       name: month_bookings

diff --git a/tests_metricflow/query_rendering/test_time_spine_join_rendering.py b/tests_metricflow/query_rendering/test_time_spine_join_rendering.py
@@ -101,6 +101,7 @@ def test_simple_join_to_time_spine_with_queried_filter(
     )
 
 
+@pytest.mark.skip("Time constraints don't use the group by resolution DAG yet. Need to determine expected behavior.")
 @pytest.mark.sql_engine_snapshot
 def test_join_to_time_spine_with_time_constraint(
     request: FixtureRequest,