Skip to content

Commit

Permalink
removed query interface
Browse files Browse the repository at this point in the history
  • Loading branch information
DevonFulcher committed Oct 6, 2023
1 parent 404c89f commit 39ecb39
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 93 deletions.
6 changes: 6 additions & 0 deletions .changes/unreleased/Under the Hood-20231006-170905.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Under the Hood
body: Remove query interface and depend on DSI protocol instead
time: 2023-10-06T17:09:05.593372-05:00
custom:
Author: DevonFulcher
Issue: None
87 changes: 0 additions & 87 deletions metricflow/protocols/query_interface.py

This file was deleted.

8 changes: 4 additions & 4 deletions metricflow/specs/where_filter_dimension.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@
FilterCallParameterSets,
)
from dbt_semantic_interfaces.protocols.protocol_hint import ProtocolHint
from dbt_semantic_interfaces.protocols.query_interface import (
QueryInterfaceDimension,
QueryInterfaceDimensionFactory,
)
from dbt_semantic_interfaces.type_enums import TimeGranularity
from typing_extensions import override

from metricflow.errors.errors import InvalidQuerySyntax
from metricflow.protocols.query_interface import (
QueryInterfaceDimension,
QueryInterfaceDimensionFactory,
)
from metricflow.specs.column_assoc import ColumnAssociationResolver
from metricflow.specs.dimension_spec_resolver import DimensionSpecResolver
from metricflow.specs.specs import TimeDimensionSpec
Expand Down
2 changes: 1 addition & 1 deletion metricflow/specs/where_filter_entity.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@
)
from dbt_semantic_interfaces.naming.dundered import DunderedNameFormatter
from dbt_semantic_interfaces.protocols.protocol_hint import ProtocolHint
from dbt_semantic_interfaces.protocols.query_interface import QueryInterfaceEntity, QueryInterfaceEntityFactory
from dbt_semantic_interfaces.references import EntityReference
from typing_extensions import override

from metricflow.errors.errors import InvalidQuerySyntax
from metricflow.protocols.query_interface import QueryInterfaceEntity, QueryInterfaceEntityFactory
from metricflow.specs.column_assoc import ColumnAssociationResolver
from metricflow.specs.specs import EntitySpec

Expand Down
5 changes: 4 additions & 1 deletion metricflow/specs/where_filter_time_dimension.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,14 @@

from dbt_semantic_interfaces.call_parameter_sets import FilterCallParameterSets
from dbt_semantic_interfaces.protocols.protocol_hint import ProtocolHint
from dbt_semantic_interfaces.protocols.query_interface import (
QueryInterfaceTimeDimension,
QueryInterfaceTimeDimensionFactory,
)
from dbt_semantic_interfaces.type_enums import TimeGranularity
from typing_extensions import override

from metricflow.errors.errors import InvalidQuerySyntax
from metricflow.protocols.query_interface import QueryInterfaceTimeDimension, QueryInterfaceTimeDimensionFactory
from metricflow.specs.column_assoc import ColumnAssociationResolver
from metricflow.specs.dimension_spec_resolver import DimensionSpecResolver
from metricflow.specs.specs import TimeDimensionSpec
Expand Down

0 comments on commit 39ecb39

Please sign in to comment.