WIP

dbt-labs · Jul 9, 2024 · 0c1d3ab · 0c1d3ab
1 parent 56e3990
commit 0c1d3ab
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 3 deletions.
diff --git a/.changes/unreleased/Features-20240628-074617.yaml b/.changes/unreleased/Features-20240628-074617.yaml
@@ -1,5 +1,5 @@
 kind: Features
-body: Use default_grain to resolve metric_time.
+body: Use default_granularity to resolve metric_time.
 time: 2024-06-28T07:46:17.768805-07:00
 custom:
   Author: courtneyholcomb

diff --git a/metricflow-semantics/metricflow_semantics/query/group_by_item/group_by_item_resolver.py b/metricflow-semantics/metricflow_semantics/query/group_by_item/group_by_item_resolver.py
@@ -104,8 +104,16 @@ def resolve_matching_item_for_querying(
                 issue_set=push_down_result.issue_set,
             )
 
+        # TODO: this isn't working, figure out why
+        filter_to_use = (
+            DefaultTimeGranularityPattern(
+                metric_lookup=self._manifest_lookup.metric_lookup, queried_metrics=queried_metrics
+            )
+            if queried_metrics
+            else 
+        )
         push_down_result = push_down_result.filter_candidates_by_pattern(
-            BaseTimeGrainPattern(),
+            filter_to_use,
         )
         logger.info(
             f"Spec pattern:\n"

diff --git a/...cs/metricflow_semantics/test_helpers/semantic_manifest_yamls/simple_manifest/metrics.yaml b/...cs/metricflow_semantics/test_helpers/semantic_manifest_yamls/simple_manifest/metrics.yaml
@@ -92,6 +92,7 @@ metric:
   type: simple
   type_params:
     measure: listings
+  default_granularity: day
 ---
 metric:
   name: "lux_listings"
@@ -100,20 +101,23 @@ metric:
   type_params:
     measure: listings
   filter: "{{ Dimension('listing__is_lux_latest') }}"
+  default_granularity: day
 ---
 metric:
   name: "smallest_listing"
   description: "smallest listing"
   type: simple
   type_params:
     measure: smallest_listing
+  default_granularity: day
 ---
 metric:
   name: "largest_listing"
   description: "largest listing"
   type: simple
   type_params:
     measure: largest_listing
+  default_granularity: day
 ---
 metric:
   name: "identity_verifications"
@@ -769,6 +773,7 @@ metric:
   type_params:
     measure: listings
   filter: "{{ Metric('bookings', ['listing']) }} > 2"
+  default_granularity: day
 ---
 metric:
   name: popular_listing_bookings_per_booker
@@ -780,3 +785,4 @@ metric:
     denominator:
       name: listings
   filter: "{{ Metric('views', ['listing']) }} > 10"
+  default_granularity: day
diff --git a/...test_helpers/semantic_manifest_yamls/simple_manifest/semantic_models/listings_latest.yaml b/...test_helpers/semantic_manifest_yamls/simple_manifest/semantic_models/listings_latest.yaml
@@ -26,7 +26,7 @@ semantic_model:
       type: time
       expr: created_at
       type_params:
-        time_granularity: day
+        time_granularity: second
     - name: created_at
       type: time
       type_params: