Skip to content

Commit

Permalink
WIP - SCD bug fix
Browse files Browse the repository at this point in the history
  • Loading branch information
courtneyholcomb committed Nov 8, 2024
1 parent 62aa3e8 commit 088e4d3
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions metricflow/dataset/convert_semantic_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,7 @@ def _convert_time_dimension(
)
time_dimension_instances.append(time_dimension_instance)

# TODO: figure out how to repro this bug https://dbt-labs.slack.com/archives/C06UEFM66P5/p1730317825261629
# Until we support minimal granularities, we cannot truncate for
# any time dimension used as part of a validity window, since a validity window might
# be stored in seconds while we would truncate to daily.
Expand Down

0 comments on commit 088e4d3

Please sign in to comment.