Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Move node dataset resolver subquery ids into a separate namespace
The DataflowPlanNodeOutputDataSetResolver class extends the DataflowToSqlQueryPlanConverter class. As a result, both classes effectively do a full conversion from a DataflowPlan to a SqlQueryPlan, complete with SqlQueryPlan node_id generation. These shared the same ID prefix, which meant any call that might trigger an additional invocation of the node dataset resolver subclass could cause shifts in the subquery IDs in our SqlQueryPlan outputs even if the invocation had no material impact on the query in question. In order to reduce snapshot thrash and make our subquery IDs easier to reason about on read-through of the generated SQL, this change splits the node dataset resolver ID prefix into a dedicated value.
- Loading branch information