Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update incremental-models.md #6739

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

datapackdan
Copy link
Contributor

@datapackdan datapackdan commented Jan 8, 2025

update conditions for is_incremental() to evaluate to true based on Issue 5279

What are you changing in this pull request and why?

This update is to address Issue 5279 - Understand the is_incremental() macro

I believe the original intent of the first two conditions was to say: "the model has to exist as a table" however saying this using two lines feels redundant and I know from training sessions that users react much the same way as the author of this issue.

I'm proposing the following wording:

Revised

The is_incremental() macro powers incremental materializations. It will return True if all of the following conditions are met:

  • The model must already exist as a table in the database
  • The full-refresh flag is not passed
  • The running model is configured with materialized='incremental'

Original (for reference)

The is_incremental() macro powers incremental materializations. It will return True if all of the following conditions are met:

  • The model must already exist in the database
  • The destination table already exists in the database
  • The full-refresh flag is not passed
  • The running model is configured with materialized='incremental'

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

🚀 Deployment available! Here are the direct links to the updated files:

update conditions for is_incremental() to evaluate to true based on Issue 5279
@datapackdan datapackdan requested a review from a team as a code owner January 8, 2025 19:31
Copy link

welcome bot commented Jan 8, 2025

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Jan 8, 2025 7:31pm

@runleonarun runleonarun added the new contributor Label for first-time contributors label Jan 8, 2025
@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Jan 8, 2025
@matthewshaver matthewshaver merged commit 495a66d into current Jan 8, 2025
12 checks passed
@matthewshaver matthewshaver deleted the datapackdan-patch-issue-5279 branch January 8, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants