Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding dbt-watsonx-presto setup and config files #6736

Open
wants to merge 4 commits into
base: current
Choose a base branch
from

Conversation

KNagaVivek
Copy link

What are you changing in this pull request and why?

Adding dbt-watsonx-presto setup and config files since dbt-watsonx-presto adapter

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

Copy link

welcome bot commented Jan 8, 2025

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

Copy link

vercel bot commented Jan 8, 2025

@KNagaVivek is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

@runleonarun runleonarun added the new contributor Label for first-time contributors label Jan 8, 2025
@github-actions github-actions bot added content Improvements or additions to content size: medium This change will take up to a week to address labels Jan 8, 2025
Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Jan 8, 2025 8:30pm

@amychen1776 amychen1776 self-assigned this Jan 9, 2025
@KNagaVivek KNagaVivek marked this pull request as ready for review January 10, 2025 01:50
@KNagaVivek KNagaVivek requested a review from a team as a code owner January 10, 2025 01:50

## Host parameters

The following profile fields are required for configuring watsonx.data Presto(java) connections. Currently, it supports only the `BasicAuth` authentication method. For IBM watsonx.data SaaS or Software instances, You can get the hostname and port details by clicking View connect details inside the Presto(java) engine details page.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The following profile fields are required for configuring watsonx.data Presto(java) connections. Currently, it supports only the `BasicAuth` authentication method. For IBM watsonx.data SaaS or Software instances, You can get the hostname and port details by clicking View connect details inside the Presto(java) engine details page.
The following profile fields are required for configuring watsonx.data Presto(java) connections. Currently, it supports only the `BasicAuth` authentication method. For IBM watsonx.data SaaS or Software instances, you can get the hostname and port details by clicking View connect details inside the Presto(java) engine details page.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph is also a tad confusing to me - does the adapter support only BasicAuth for authentication? Also I assume host and port details are required fields regardless ?


| Option | Required/Optional | Description | Example |
| --------- | ------- | ------- | ----------- |
| `method` | Required (default value is none) | Authentication method for Presto | `None` or `BasicAuth` |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would the user ever want to put in None?

| --------- | ------- | ------- | ----------- |
| `method` | Required (default value is none) | Authentication method for Presto | `None` or `BasicAuth` |
| `user` | Required | Username or email for authentication. | `user` |
| `password`| Required (if `method` is `BasicAuth`) | Password or API key for authentication | `password` |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the adapter only supports basicauth - I would just put this as required


## Instance requirements

To use IBM watsonx.data Presto(java) with dbt, ensure the instance has an attached catalog that allows creating, renaming, altering, and dropping objects such as tables and views. The user connecting to the instance with dbt must have equivalent permissions for the target catalog.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any docs on the IBM side that we can link to to help users find out more?

```

## Seeds and prepared statements
The `dbt-watsonx-presto` adapter offers comprehensive support for all [Presto datatypes](https://prestodb.io/docs/current/language/types.html) and [watsonx.data Presto datatypes](https://www.ibm.com/support/pages/node/7157339) in seed files. However, to utilize this feature, you need to explicitly define the data types for each column in the `dbt_project.yml` file.
Copy link
Collaborator

@amychen1776 amychen1776 Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why this has to be done in the dbt_project.yml file? We support seed configs in property files too https://docs.getdbt.com/reference/seed-configs

This would also keep the project.yml file much cleaner


### View

The `dbt-watsonx-presto` adapter supports creating views using the `materialized='view'` configuration in your dbt model. By default, when you set the materialization to view, it creates a view in watsonx.data Presto.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Views are the default setting for dbt so if the user doesn't set one, it will just create a view. I assume this is also the case for this adapter

Copy link
Collaborator

@amychen1776 amychen1776 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this! I have a few comments to ensure clarity in the documentation.

I was also curious if the adapter supports iceberg table format?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants