-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding dbt-watsonx-presto setup and config files #6736
base: current
Are you sure you want to change the base?
Conversation
Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨ |
@KNagaVivek is attempting to deploy a commit to the dbt-labs Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
||
## Host parameters | ||
|
||
The following profile fields are required for configuring watsonx.data Presto(java) connections. Currently, it supports only the `BasicAuth` authentication method. For IBM watsonx.data SaaS or Software instances, You can get the hostname and port details by clicking View connect details inside the Presto(java) engine details page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following profile fields are required for configuring watsonx.data Presto(java) connections. Currently, it supports only the `BasicAuth` authentication method. For IBM watsonx.data SaaS or Software instances, You can get the hostname and port details by clicking View connect details inside the Presto(java) engine details page. | |
The following profile fields are required for configuring watsonx.data Presto(java) connections. Currently, it supports only the `BasicAuth` authentication method. For IBM watsonx.data SaaS or Software instances, you can get the hostname and port details by clicking View connect details inside the Presto(java) engine details page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This paragraph is also a tad confusing to me - does the adapter support only BasicAuth
for authentication? Also I assume host and port details are required fields regardless ?
|
||
| Option | Required/Optional | Description | Example | | ||
| --------- | ------- | ------- | ----------- | | ||
| `method` | Required (default value is none) | Authentication method for Presto | `None` or `BasicAuth` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would the user ever want to put in None
?
| --------- | ------- | ------- | ----------- | | ||
| `method` | Required (default value is none) | Authentication method for Presto | `None` or `BasicAuth` | | ||
| `user` | Required | Username or email for authentication. | `user` | | ||
| `password`| Required (if `method` is `BasicAuth`) | Password or API key for authentication | `password` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the adapter only supports basicauth - I would just put this as required
|
||
## Instance requirements | ||
|
||
To use IBM watsonx.data Presto(java) with dbt, ensure the instance has an attached catalog that allows creating, renaming, altering, and dropping objects such as tables and views. The user connecting to the instance with dbt must have equivalent permissions for the target catalog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any docs on the IBM side that we can link to to help users find out more?
``` | ||
|
||
## Seeds and prepared statements | ||
The `dbt-watsonx-presto` adapter offers comprehensive support for all [Presto datatypes](https://prestodb.io/docs/current/language/types.html) and [watsonx.data Presto datatypes](https://www.ibm.com/support/pages/node/7157339) in seed files. However, to utilize this feature, you need to explicitly define the data types for each column in the `dbt_project.yml` file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why this has to be done in the dbt_project.yml file? We support seed configs in property files too https://docs.getdbt.com/reference/seed-configs
This would also keep the project.yml file much cleaner
|
||
### View | ||
|
||
The `dbt-watsonx-presto` adapter supports creating views using the `materialized='view'` configuration in your dbt model. By default, when you set the materialization to view, it creates a view in watsonx.data Presto. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Views are the default setting for dbt so if the user doesn't set one, it will just create a view. I assume this is also the case for this adapter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening this! I have a few comments to ensure clarity in the documentation.
I was also curious if the adapter supports iceberg table format?
What are you changing in this pull request and why?
Adding dbt-watsonx-presto setup and config files since dbt-watsonx-presto adapter
Checklist