Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace callout w component #6709

Merged
merged 10 commits into from
Dec 23, 2024
Merged

replace callout w component #6709

merged 10 commits into from
Dec 23, 2024

Conversation

mirnawong1
Copy link
Contributor

@mirnawong1 mirnawong1 commented Dec 23, 2024

replacing hardcoded callouts with the VersionCallout component for uniformity and scability.

Natalie to add the component to the following pages:

  • website/docs/reference/resource-configs/snapshot_meta_column_names.md
  • website/docs/docs/build/unit-tests.md

🚀 Deployment available! Here are the direct links to the updated files:

@mirnawong1 mirnawong1 requested a review from a team as a code owner December 23, 2024 12:30
Copy link

vercel bot commented Dec 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Dec 23, 2024 3:38pm

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address Docs team Authored by the Docs team @dbt Labs labels Dec 23, 2024
@@ -14,7 +14,7 @@ Running with dbt=1.0.0
Found 13 models, 2 tests, 1 archives, 0 analyses, 204 macros, 2 operations....
```

:::info dbt Cloud release tracks
:::note dbt Cloud release tracks
<Snippet path="_config-dbt-version-check" />
Copy link
Contributor

@nataliefiann nataliefiann Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @mirnawong1

This is more of a question / suggestion. Just thinking of customers who may be visually impaired (this wasn't part of your PR btw) - is it possible to make the background a different colour as the text in the toggle / expandable is quite hard to read.

Kind Regards
Natalie

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea this callout does need tweaking -- currently this is how it looks like in dark mode and i changed the callout from info to note so it's at least visible. but the component actually needs updating so the expandable color changes in dark mode:

Screenshot 2024-12-23 at 15 36 47

Copy link
Contributor

@nataliefiann nataliefiann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @mirnawong1

Thanks for creating this PR and component. I've approved this for you and left one question but the question isn't related to anything you created in this PR.

Kind Regards
Natalie

@mirnawong1 mirnawong1 merged commit 567d744 into current Dec 23, 2024
8 checks passed
@mirnawong1 mirnawong1 deleted the add-version-callout branch December 23, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants