Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[do not merge] saved queries support tags #6632

Open
wants to merge 18 commits into
base: current
Choose a base branch
from
Open

Conversation

mirnawong1
Copy link
Contributor

@mirnawong1 mirnawong1 commented Dec 10, 2024

@mirnawong1 mirnawong1 requested a review from a team as a code owner December 10, 2024 10:35
Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Dec 23, 2024 10:23am

@github-actions github-actions bot added content Improvements or additions to content size: medium This change will take up to a week to address Docs team Authored by the Docs team @dbt Labs labels Dec 10, 2024
@mirnawong1 mirnawong1 changed the title [do not merge] exports support tags [do not merge] saved queries support tags Dec 11, 2024
@github-actions github-actions bot added size: large This change will more than a week to address and might require more than one person and removed size: medium This change will take up to a week to address labels Dec 11, 2024
Copy link

@theyostalservice theyostalservice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all your work on this, Mirna!

@@ -17,8 +17,32 @@ To create a saved query, refer to the following table parameters.
:::tip
Note that we use the double colon (::) to indicate whether a parameter is nested within another parameter. So for example, `query_params::metrics` means the `metrics` parameter is nested under `query_params`.
:::

<!-- For versions 1.9 and higher -->
<VersionBlock firstVersion="1.9">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review this as I'm not sure what has changed and it doesn't seem related to tags

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good shout! just added that tags are supported in 1.9+ under the config value:
Screenshot 2024-12-23 at 11 43 39

Comment on lines +233 to +236
config:
tags:
- order_metrics
- hourly

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting the tags inside the config is not how I built this to work or expected it to work, but it DOES work, so that's pretty cool, and I think it's more in line with how other things work, so... thanks for making this better I guess! lol

config:
tags: <string> | [<string>]
tags: string

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know about tags for sub-properties like columns, but since the term is plural, I'd be a little surprised if this change was correct. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: large This change will more than a week to address and might require more than one person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants