-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[do not merge] saved queries support tags #6632
base: current
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all your work on this, Mirna!
@@ -17,8 +17,32 @@ To create a saved query, refer to the following table parameters. | |||
:::tip | |||
Note that we use the double colon (::) to indicate whether a parameter is nested within another parameter. So for example, `query_params::metrics` means the `metrics` parameter is nested under `query_params`. | |||
::: | |||
|
|||
<!-- For versions 1.9 and higher --> | |||
<VersionBlock firstVersion="1.9"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't review this as I'm not sure what has changed and it doesn't seem related to tags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
config: | ||
tags: | ||
- order_metrics | ||
- hourly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Putting the tags inside the config is not how I built this to work or expected it to work, but it DOES work, so that's pretty cool, and I think it's more in line with how other things work, so... thanks for making this better I guess! lol
config: | ||
tags: <string> | [<string>] | ||
tags: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know about tags for sub-properties like columns, but since the term is plural, I'd be a little surprised if this change was correct. :/
this pr adds a new feature where saved queries supports
tags
.currently waiting for eng update on this as still working through
notion docs project
🚀 Deployment available! Here are the direct links to the updated files: