Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sample code to handle new dbt log line #6523

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

joellabes
Copy link
Contributor

@joellabes joellabes commented Nov 22, 2024

What are you changing in this pull request and why?

Slack thread

dbt now sometimes includes partial successes in its end of run summary line, which weren't picked up by the current regex for Slack results. Updated the regex accordingly (and asked the Cloud team for json logs)

Before and after:
image

@joellabes joellabes requested a review from a team as a code owner November 22, 2024 03:31
Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Nov 22, 2024 2:24pm

@github-actions github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides size: x-small This change will take under 3 hours to fix. labels Nov 22, 2024
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@mirnawong1 mirnawong1 enabled auto-merge November 22, 2024 14:17
@mirnawong1 mirnawong1 merged commit c13dd43 into current Nov 22, 2024
8 of 9 checks passed
@mirnawong1 mirnawong1 deleted the zapier-slack-handle-new-core-output branch November 22, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content guides Knowledge best suited for Guides size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants