Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancing table borders #6481

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Enhancing table borders #6481

merged 4 commits into from
Nov 14, 2024

Conversation

matthewshaver
Copy link
Contributor

@matthewshaver matthewshaver commented Nov 13, 2024 •
edited
Loading

What are you changing in this pull request and why?

Makes the table borders thicker for dark and light mode to enhance readability

(Optional - pending feedback): Make the header background orange to match our logo [Edit] Team voted Yes for this

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

@matthewshaver matthewshaver requested a review from a team as a code owner November 13, 2024 23:43
@vercel Vercel
Copy link

vercel bot commented Nov 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Nov 14, 2024 5:50pm

@github-actions github-actions bot added size: small This change will take 1 to 2 days to address Docs team Authored by the Docs team @dbt Labs labels Nov 13, 2024
nataliefiann
nataliefiann approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@nataliefiann nataliefiann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @matthewshaver

I love this! I love the dbt orange. It's a nice touch and really stands out.

Kind Regards
Natalie

@matthewshaver matthewshaver merged commit d2e203e into current Nov 14, 2024
11 checks passed
@matthewshaver matthewshaver deleted the table-border branch November 14, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nataliefiann nataliefiann nataliefiann approved these changes

Assignees
No one assigned
Labels
Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewshaver @nataliefiann