Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shorthand SL order syntax for JDBC api #6434

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

bthomson22
Copy link
Contributor

@bthomson22 bthomson22 commented Nov 7, 2024

What are you changing in this pull request and why?

The order by (short hand) syntax is listed as -'dimension_name' - when I tested this locally it didn't work, and provided the below error:

Validation errors for executable:
Only list, string, integer, boolean, None, or call arguments are allowed.

I moved the - into the quotations and it worked as expected. '-dimension_name'

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

🚀 Deployment available! Here are the direct links to the updated files:

The `-` needs to be nested in the quotes - tested this locally to ensure it works.
@bthomson22 bthomson22 requested a review from a team as a code owner November 7, 2024 18:42
Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Nov 7, 2024 6:43pm

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Nov 7, 2024
@mirnawong1 mirnawong1 enabled auto-merge November 7, 2024 18:46
@mirnawong1 mirnawong1 merged commit 6eee8a7 into current Nov 7, 2024
15 of 16 checks passed
@mirnawong1 mirnawong1 deleted the fix/update-jdbc-order-by-syntax branch November 7, 2024 18:47
@mirnawong1
Copy link
Contributor

Oh great catch! Thanks so much for opening this up @bthomson22 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants