Metric date #6428
Merged
Metric date #6428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
courtneyholcomb
approved these changes
Nov 6, 2024
website/docs/docs/build/measures.md
Outdated
| @@ -200,16 +200,16 @@ Parameters under the `non_additive_dimension` will specify dimensions that the m | |||
|
|
|||
| ```yaml | |||
| semantic_models: | |||
| - name: subscription_id | |||
| - name: subscription | |||
There was a problem hiding this comment.
Can we make this subscriptions (plural)?
website/docs/docs/build/measures.md
Outdated
| description: A subscription table with one row per date for each active user and their subscription plans. | ||
| model: ref('your_schema.subscription_table') | ||
| model: ref('your_schema.subscription') |
There was a problem hiding this comment.
You can leave this how it was! The table name doesn't need to match the semantic model name.
| defaults: | ||
| agg_time_dimension: subscription_date | ||
|
|
||
| entities: | ||
| - name: user_id | ||
| type: foreign | ||
| primary_entity: subscription_table | ||
| primary_entity: subscription |
There was a problem hiding this comment.
This and everything below looks good!
matthewshaver
commented
Nov 7, 2024
matthewshaver
commented
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing in this pull request and why?
Enhancing examples https://dbt-labs.slack.com/archives/C02NCQ9483C/p1730927629130439
Checklist
🚀 Deployment available! Here are the direct links to the updated files: