Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update advanced ci #6378

Merged
merged 5 commits into from
Oct 29, 2024
Merged

update advanced ci #6378

merged 5 commits into from
Oct 29, 2024

Conversation

mirnawong1
Copy link
Contributor

@mirnawong1 mirnawong1 commented Oct 29, 2024

@mirnawong1 mirnawong1 requested a review from a team as a code owner October 29, 2024 14:35
Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Oct 29, 2024 3:12pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address labels Oct 29, 2024
Copy link

@mikaylacrawford mikaylacrawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

website/docs/docs/deploy/ci-jobs.md Outdated Show resolved Hide resolved
Copy link
Contributor

@nataliefiann nataliefiann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @mirnawong1

Thank you for creating this doc. I've approved this for you.
Just to note, I added some non-blocking suggestions (these were in the white sections) I wasn't sure if it's worth adding those but thought I'd let you know.

Kind Regards
Natalie

@mirnawong1 mirnawong1 merged commit 2725b35 into current Oct 29, 2024
13 checks passed
@mirnawong1 mirnawong1 deleted the update-dbt-compare branch October 29, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants