Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oct MF release notes and jdbc #6377

Merged
merged 16 commits into from
Oct 30, 2024
Merged

oct MF release notes and jdbc #6377

merged 16 commits into from
Oct 30, 2024

Conversation

mirnawong1
Copy link
Contributor

@mirnawong1 mirnawong1 commented Oct 29, 2024

this pr adds the oct SL release notes as mentioned in linear, as well as adds metadata calls for the jdbc doc.


🚀 Deployment available! Here are the direct links to the updated files:

@mirnawong1 mirnawong1 requested a review from a team as a code owner October 29, 2024 11:55
Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Oct 30, 2024 4:58pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address labels Oct 29, 2024
@github-actions github-actions bot added size: medium This change will take up to a week to address and removed size: small This change will take 1 to 2 days to address labels Oct 29, 2024
Copy link
Contributor

@nataliefiann nataliefiann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @mirnawong1

Thanks for creating this. I've approved this for you but also left a suggestion and some non-blocking suggestions. I also amended some small grammar / punctuation things.

Kind Regards
Natalie


<Expandable alt_header="Paginate metadata calls">

In cases where user manifests are large, pagination is a useful way to prevent query character limits in the data platform. You can paginate results for both `semantic_layer.metrics()` and `semantic_layer.dimensions()` calls using the `page_size` and `page_number` parameters.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"In cases where user manifests are large, pagination is a useful way to prevent query character limits in the data platform. You can paginate results"

Change to: "In the case when you don't want to return the full result set from a metadata call you can paginate the resluts.."


In cases where user manifests are large, pagination is a useful way to prevent query character limits in the data platform. You can paginate results for both `semantic_layer.metrics()` and `semantic_layer.dimensions()` calls using the `page_size` and `page_number` parameters.

- `page_size`: This is an optional feature which sets the number of records per page. If left as `None`, there is no page limit.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to --> This is an optional variable which sets the number of records per page. If left as None, there is no page limit.

In cases where user manifests are large, pagination is a useful way to prevent query character limits in the data platform. You can paginate results for both `semantic_layer.metrics()` and `semantic_layer.dimensions()` calls using the `page_size` and `page_number` parameters.

- `page_size`: This is an optional feature which sets the number of records per page. If left as `None`, there is no page limit.
- `page_number`: This is another optional feature which specifies the page number to retrieve. Defaults to `1` (first page) if not specified.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

Copy link
Contributor

@Jstein77 Jstein77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@runleonarun runleonarun merged commit 8459a73 into current Oct 30, 2024
13 checks passed
@runleonarun runleonarun deleted the oct-sl-rn branch October 30, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants