-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oct MF release notes and jdbc #6377
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: nataliefiann <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hiya @mirnawong1
Thanks for creating this. I've approved this for you but also left a suggestion and some non-blocking suggestions. I also amended some small grammar / punctuation things.
Kind Regards
Natalie
Co-authored-by: nataliefiann <[email protected]>
Co-authored-by: nataliefiann <[email protected]>
|
||
<Expandable alt_header="Paginate metadata calls"> | ||
|
||
In cases where user manifests are large, pagination is a useful way to prevent query character limits in the data platform. You can paginate results for both `semantic_layer.metrics()` and `semantic_layer.dimensions()` calls using the `page_size` and `page_number` parameters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"In cases where user manifests are large, pagination is a useful way to prevent query character limits in the data platform. You can paginate results"
Change to: "In the case when you don't want to return the full result set from a metadata call you can paginate the resluts.."
|
||
In cases where user manifests are large, pagination is a useful way to prevent query character limits in the data platform. You can paginate results for both `semantic_layer.metrics()` and `semantic_layer.dimensions()` calls using the `page_size` and `page_number` parameters. | ||
|
||
- `page_size`: This is an optional feature which sets the number of records per page. If left as `None`, there is no page limit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to --> This is an optional variable which sets the number of records per page. If left as None
, there is no page limit.
In cases where user manifests are large, pagination is a useful way to prevent query character limits in the data platform. You can paginate results for both `semantic_layer.metrics()` and `semantic_layer.dimensions()` calls using the `page_size` and `page_number` parameters. | ||
|
||
- `page_size`: This is an optional feature which sets the number of records per page. If left as `None`, there is no page limit. | ||
- `page_number`: This is another optional feature which specifies the page number to retrieve. Defaults to `1` (first page) if not specified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
this pr adds the oct SL release notes as mentioned in linear, as well as adds metadata calls for the jdbc doc.
🚀 Deployment available! Here are the direct links to the updated files: