Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Athena quickstart #6354

Merged
merged 16 commits into from
Nov 21, 2024
Merged

Athena quickstart #6354

merged 16 commits into from
Nov 21, 2024

Conversation

matthewshaver
Copy link
Contributor

@matthewshaver matthewshaver commented Oct 24, 2024 •
edited by github-actions bot
Loading

What are you changing in this pull request and why?

Athena quickstart

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

🚀 Deployment available! Here are the direct links to the updated files:

@matthewshaver matthewshaver requested a review from a team as a code owner October 24, 2024 13:13
@vercel Vercel
Copy link

vercel bot commented Oct 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Nov 21, 2024 8:24pm

@matthewshaver matthewshaver marked this pull request as draft October 24, 2024 13:13
@github-actions github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides size: medium This change will take up to a week to address Docs team Authored by the Docs team @dbt Labs labels Oct 24, 2024
@github-actions github-actions bot added size: large This change will more than a week to address and might require more than one person and removed size: medium This change will take up to a week to address labels Nov 4, 2024
@matthewshaver matthewshaver marked this pull request as ready for review November 4, 2024 17:27
@matthewshaver matthewshaver changed the title [DRAFT] Athena quickstart Athena quickstart Nov 4, 2024
@matthewshaver matthewshaver changed the title Athena quickstart DOCS-4 Athena quickstart Nov 5, 2024
@matthewshaver matthewshaver changed the title DOCS-4 Athena quickstart Athena quickstart Nov 5, 2024
runleonarun
runleonarun reviewed Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewshaver Some initial edits.

website/docs/guides/athena-qs.md Outdated Show resolved Hide resolved
website/docs/guides/athena-qs.md Outdated Show resolved Hide resolved
website/docs/guides/athena-qs.md Outdated Show resolved Hide resolved
website/docs/guides/athena-qs.md Outdated Show resolved Hide resolved
website/docs/guides/athena-qs.md Outdated Show resolved Hide resolved
website/docs/guides/athena-qs.md Outdated Show resolved Hide resolved
website/docs/guides/athena-qs.md Outdated Show resolved Hide resolved
website/docs/guides/athena-qs.md Outdated Show resolved Hide resolved
website/docs/guides/athena-qs.md Outdated Show resolved Hide resolved
website/docs/guides/athena-qs.md Show resolved Hide resolved
matthewshaver
matthewshaver commented Nov 8, 2024
View reviewed changes
website/docs/guides/athena-qs.md

Save the `aws_access_key_id` and `aws_secret_access_key` for a future step.

### AWS credentials file
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amychen1776 Should we even include this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep this!

amychen1776
amychen1776 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@amychen1776 amychen1776 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@amychen1776 amychen1776 merged commit 6efb386 into current Nov 21, 2024
9 checks passed
@amychen1776 amychen1776 deleted the athena-qs branch November 21, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amychen1776 amychen1776 amychen1776 approved these changes

@runleonarun runleonarun Awaiting requested review from runleonarun

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs guides Knowledge best suited for Guides size: large This change will more than a week to address and might require more than one person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewshaver @runleonarun @amychen1776