-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update data test descriptions #6307
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hey @matthewshaver , do you think we should modify one of the examples under the 'examples' header to include tests? e.g.
|
also it maybe out of scope but would it be a good idea to link to the description property page here? |
Good questions @mirnawong1 - I only updated to stress all data tests in the description. There was an earlier PR from some others that didn't do it then. Maybe because it would be a lot of version blocking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @matthewshaver !
My vote is to add some examples, even if they're not truly inside of version blocks and just have a comment beside them or something. I was just sharing info on how this worked, and wound up having to backsolve it myself instead of using the docs. A couple of examples are here if you want to leverage them: https://discourse.getdbt.com/t/is-it-possible-to-add-a-description-to-singular-tests/5472/4 |
What are you changing in this pull request and why?
Generic Test descriptions can now be documented
Closes #6293
Checklist
🚀 Deployment available! Here are the direct links to the updated files: