Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An example of separating semantic model (pure yaml) from dbt model (yaml, sql, python) #6305

Merged
merged 5 commits into from
Oct 18, 2024

Conversation

albertlieyingadrian
Copy link
Contributor

@albertlieyingadrian albertlieyingadrian commented Oct 17, 2024

What are you changing in this pull request and why?

It isn't a clear-cut to find an example of sub-folder semantic approach. Hence, adding an example of it. Additionally, adding it to jaffle-shop repo would be wonderful.

Resolves #6306

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@albertlieyingadrian albertlieyingadrian requested a review from a team as a code owner October 17, 2024 14:06
Copy link

welcome bot commented Oct 17, 2024

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

Copy link

vercel bot commented Oct 17, 2024

@albertlieyingadrian is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

@runleonarun runleonarun added the new contributor Label for first-time contributors label Oct 17, 2024
@github-actions github-actions bot added content Improvements or additions to content size: medium This change will take up to a week to address and removed new contributor Label for first-time contributors labels Oct 17, 2024
@albertlieyingadrian
Copy link
Contributor Author

Or actually, adding a link to the tutorial of setting it up on Snowflake might be sufficient https://docs.getdbt.com/guides/sl-snowflake-qs?step=9
Screenshot 2024-10-17 at 12 48 11 PM

@albertlieyingadrian
Copy link
Contributor Author

Lmk what else I need to change @runleonarun

Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @albertlieyingadrian , this is such a great pr! really beautifully written and thank you so much for opening this up to clarify! I'll probably follow up so i can link to your new header additions from the 'semantic structure' page and the quickstart, like you suggested.

i tweaked it a little and turn the h3 headers into expandable toggles, which are also linkable, just to shorten the scrolling needed and ensure the explanation is viewed too.

I'm happy to merge this for you if you have no other comments/feedback. thank you again, this is such a great PR! ✨

@albertlieyingadrian
Copy link
Contributor Author

No other comments. Please merge @mirnawong1

@mirnawong1 mirnawong1 merged commit 3be754d into dbt-labs:current Oct 18, 2024
2 of 4 checks passed
@jinjakim
Copy link

jinjakim commented Oct 21, 2024

@albertlieyingadrian Woah this was you? - I was impressed on how the documentation had improved over the course of a week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An example of semantic model - parallel subfolder approach
4 participants